Skip to content

Commit 8f150e8

Browse files
committed
storage capacity: review feedback
1 parent 9d85d7e commit 8f150e8

File tree

1 file changed

+7
-2
lines changed
  • keps/sig-storage/1472-storage-capacity-tracking

1 file changed

+7
-2
lines changed

keps/sig-storage/1472-storage-capacity-tracking/README.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -857,11 +857,14 @@ enhancement:
857857
communication issues with the API server.
858858

859859
The new flag in `CSIDriver` will be preserved when disabling the
860-
feature gate or when rolling back to a release older than 1.19. kube-scheduler
861-
will continue to do scheduling with capacity information until it also
860+
feature gate in the apiserver. kube-scheduler
861+
will continue to do scheduling with capacity information until it
862862
gets rolled back to a version without support for that or the feature
863863
is turned off for kube-scheduler.
864864

865+
The new flag is not preserved when rolling back to a release older
866+
than 1.19 where the flag did not exist yet.
867+
865868
* **What happens if we reenable the feature if it was previously rolled back?**
866869

867870
Stale objects will either get garbage collected via their ownership relationship
@@ -939,6 +942,8 @@ following metric data that will be provided by external-provisioner instances:
939942
The CSI driver name will be used as label. When using distributed
940943
provisioning, the node name will be used as additional label.
941944

945+
TODO: mention the exact metrics names once they are implemented.
946+
942947
* **What are the SLIs (Service Level Indicators) an operator can use to
943948
determine the health of the service?**
944949

0 commit comments

Comments
 (0)