Skip to content

Commit 94bd667

Browse files
committed
Add PRR review fixes
1 parent c1ea401 commit 94bd667

File tree

1 file changed

+3
-2
lines changed
  • keps/sig-network/1860-kube-proxy-IP-node-binding

1 file changed

+3
-2
lines changed

keps/sig-network/1860-kube-proxy-IP-node-binding/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,9 @@ features, like PROXY and TLS Termination as per the Motivations section).
202202

203203
###### What specific metrics should inform a rollback?
204204

205-
N/A
205+
If using kube-proxy, looking at metrics `sync_proxy_rules_duration_seconds` and
206+
`sync_proxy_rules_last_timestamp_seconds` may help identifying problems and indications
207+
of a required rollback.
206208

207209
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
208210

@@ -243,7 +245,6 @@ N/A
243245

244246
* On kube-proxy, a metric containing the count of IP programming vs service type would be useful
245247
to determine if the feature is being used, and if there is any drift between nodes
246-
* TBD: Should this metric be implemented?
247248

248249
### Dependencies
249250

0 commit comments

Comments
 (0)