KEP-4368: Job API managed-by label (kubernetes#4370)

* Support batch labels for jobs

* Review remarks

* Drop the point about multiple conditions

* Add point about compatibility with CronJob

* Explicit note on mutability

* Extend the unit test scenarios

* Add a note about new version with disabled feature gate

* Add a note on debuggability

* points added

* propose the new metric

* update the MultiKueue link

* typo

* Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/README.md

Co-authored-by: Maciej Szulik <[email protected]>

* Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/README.md

Co-authored-by: Maciej Szulik <[email protected]>

* Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/README.md

Co-authored-by: Maciej Szulik <[email protected]>

* Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/README.md

Co-authored-by: Maciej Szulik <[email protected]>

* add a note about the SLOs

* add a note about the downgrade

* note about the apiservers

* add a note about using the metric to find out the feature is used

* add tests for the metric

* Add validation rules to prevent problems for CronJob

* Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/README.md

Co-authored-by: Aldo Culquicondor <[email protected]>

* Added the validation rules

* metion the strengtening of the CronJob implementation

* cleanup

* add note about multiKueue

* add a note about coverage for validation package

* Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/README.md

Co-authored-by: Filip Křepinský <[email protected]>

* add a GA graduation point to look for other implementations
and conformance with k8s

* Status fields for indexes are non-nil only when completionMode: Indexed

* clarifications

* add to the reasons for rollback section

* Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/README.md

Co-authored-by: Aldo Culquicondor <[email protected]>

* Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/README.md

Co-authored-by: Aldo Culquicondor <[email protected]>

* Add notes about tests

* add a note about risk on rollback

* cleanup the skew version paragraph

* grammar fix

* paragraph cleanup

* Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/kep.yaml

Co-authored-by: Tim Bannister <[email protected]>

* Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/kep.yaml

Co-authored-by: Tim Bannister <[email protected]>

* Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/kep.yaml

Co-authored-by: Tim Bannister <[email protected]>

* Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/README.md

Co-authored-by: Tim Bannister <[email protected]>

* Change quotes for the managed-by label

* mention the full name early in the doc

* Add alternative names section

* Update keps/sig-apps/4368-support-managed-by-label-for-batch-jobs/README.md

Co-authored-by: Maciej Szulik <[email protected]>

* Review remarks about the e2e tests and upgrade testing

* add checkpoints

* fix the nit

---------

Co-authored-by: Maciej Szulik <[email protected]>
Co-authored-by: Aldo Culquicondor <[email protected]>
Co-authored-by: Filip Křepinský <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>

Author: 5 people

keps/prod-readiness/sig-apps/4368.yaml

@@ -0,0 +1,3 @@
+kep-number: 4368
+beta:
+  approver: "@wojtek-t"