Skip to content

Commit 95d2d31

Browse files
committed
Update test plan to use the new test plan template
1 parent eb33dbc commit 95d2d31

File tree

1 file changed

+19
-9
lines changed
  • keps/sig-network/2593-multiple-cluster-cidrs

1 file changed

+19
-9
lines changed

keps/sig-network/2593-multiple-cluster-cidrs/README.md

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,10 @@
3333
- [ClusterCIDRConfig Deleted](#clustercidrconfig-deleted)
3434
- [kube-controller-manager](#kube-controller-manager)
3535
- [Test Plan](#test-plan)
36-
- [Unit Tests and Benchmarks](#unit-tests-and-benchmarks)
37-
- [Integration Tests](#integration-tests)
38-
- [End-to-End Tests](#end-to-end-tests)
36+
- [Prerequisite testing updates](#prerequisite-testing-updates)
37+
- [Unit tests](#unit-tests)
38+
- [Integration tests](#integration-tests)
39+
- [e2e tests](#e2e-tests)
3940
- [Graduation Criteria](#graduation-criteria)
4041
- [Alpha to Beta Graduation](#alpha-to-beta-graduation)
4142
- [Beta to GA Graduation](#beta-to--ga-graduation)
@@ -578,26 +579,35 @@ The list of current valid types is
578579
579580
### Test Plan
580581
581-
#### Unit Tests and Benchmarks
582+
[X] I/we understand the owners of the involved components may require updates to
583+
existing tests to make this code solid enough prior to committing the changes necessary
584+
to implement this enhancement.
582585
583-
- Ensure that the controller scales to ~5,000 nodes -- memory usage and
584-
reasonable allocation times
586+
##### Prerequisite testing updates
585587
586-
#### Integration Tests
588+
N/A
589+
590+
##### Unit tests
591+
592+
- Ensure that the controller scales to ~5,000 nodes -- memory usage and
593+
reasonable allocation times.
594+
- k8s.io/kubernetes/pkg/controller/nodeipam: 06/21/2022 - 51.2
595+
596+
##### Integration tests
587597
588598
- Verify finalizers and statuses are persisted appropriately
589599
- Test watchers
590600
- Ensure that the controller handles the feature being disabled and re-enabled:
591601
- Test with some Nodes already having `PodCIDR` allocations
592602
593-
#### End-to-End Tests
603+
##### e2e tests
594604
595605
- Run through some sample workflows. Just a few for example:
596606
- Adding a node
597607
- Adding a ClusterCIDRConfig
598608
- Deleting a ClusterCIDRConfig that is in use
599609
- Run through the [user stories](#user-stories):
600-
- Expand the ClusterCIDR (existing nodes without alloations are
610+
- Expand the ClusterCIDR (existing nodes without allocations are
601611
allocated and new nodes also get ranges.
602612
- Use `NodeSelector` to allocate different sized CIDRs to different nodes.
603613
- Create and use discontiguous ranges.

0 commit comments

Comments
 (0)