|
33 | 33 | - [ClusterCIDRConfig Deleted](#clustercidrconfig-deleted)
|
34 | 34 | - [kube-controller-manager](#kube-controller-manager)
|
35 | 35 | - [Test Plan](#test-plan)
|
36 |
| - - [Unit Tests and Benchmarks](#unit-tests-and-benchmarks) |
37 |
| - - [Integration Tests](#integration-tests) |
38 |
| - - [End-to-End Tests](#end-to-end-tests) |
| 36 | + - [Prerequisite testing updates](#prerequisite-testing-updates) |
| 37 | + - [Unit tests](#unit-tests) |
| 38 | + - [Integration tests](#integration-tests) |
| 39 | + - [e2e tests](#e2e-tests) |
39 | 40 | - [Graduation Criteria](#graduation-criteria)
|
40 | 41 | - [Alpha to Beta Graduation](#alpha-to-beta-graduation)
|
41 | 42 | - [Beta to GA Graduation](#beta-to--ga-graduation)
|
@@ -578,26 +579,35 @@ The list of current valid types is
|
578 | 579 |
|
579 | 580 | ### Test Plan
|
580 | 581 |
|
581 |
| -#### Unit Tests and Benchmarks |
| 582 | +[X] I/we understand the owners of the involved components may require updates to |
| 583 | +existing tests to make this code solid enough prior to committing the changes necessary |
| 584 | +to implement this enhancement. |
582 | 585 |
|
583 |
| -- Ensure that the controller scales to ~5,000 nodes -- memory usage and |
584 |
| - reasonable allocation times |
| 586 | +##### Prerequisite testing updates |
585 | 587 |
|
586 |
| -#### Integration Tests |
| 588 | +N/A |
| 589 | +
|
| 590 | +##### Unit tests |
| 591 | +
|
| 592 | +- Ensure that the controller scales to ~5,000 nodes -- memory usage and |
| 593 | + reasonable allocation times. |
| 594 | +- k8s.io/kubernetes/pkg/controller/nodeipam: 06/21/2022 - 51.2 |
| 595 | +
|
| 596 | +##### Integration tests |
587 | 597 |
|
588 | 598 | - Verify finalizers and statuses are persisted appropriately
|
589 | 599 | - Test watchers
|
590 | 600 | - Ensure that the controller handles the feature being disabled and re-enabled:
|
591 | 601 | - Test with some Nodes already having `PodCIDR` allocations
|
592 | 602 |
|
593 |
| -#### End-to-End Tests |
| 603 | +##### e2e tests |
594 | 604 |
|
595 | 605 | - Run through some sample workflows. Just a few for example:
|
596 | 606 | - Adding a node
|
597 | 607 | - Adding a ClusterCIDRConfig
|
598 | 608 | - Deleting a ClusterCIDRConfig that is in use
|
599 | 609 | - Run through the [user stories](#user-stories):
|
600 |
| - - Expand the ClusterCIDR (existing nodes without alloations are |
| 610 | + - Expand the ClusterCIDR (existing nodes without allocations are |
601 | 611 | allocated and new nodes also get ranges.
|
602 | 612 | - Use `NodeSelector` to allocate different sized CIDRs to different nodes.
|
603 | 613 | - Create and use discontiguous ranges.
|
|
0 commit comments