Skip to content

Commit 9624dc8

Browse files
authored
Merge pull request kubernetes#3419 from ruiwen-zhao/test
KEP-2133: Update test plan
2 parents 8fd3f73 + c0a26ac commit 9624dc8

File tree

2 files changed

+69
-1
lines changed

2 files changed

+69
-1
lines changed

keps/sig-node/2133-kubelet-credential-providers/README.md

Lines changed: 68 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@
1515
- [Caching Credentials](#caching-credentials)
1616
- [Metrics](#metrics)
1717
- [Test Plan](#test-plan)
18+
- [Prerequisite testing updates](#prerequisite-testing-updates)
19+
- [Unit tests](#unit-tests)
20+
- [Integration tests](#integration-tests)
21+
- [e2e tests](#e2e-tests)
1822
- [Graduation Criteria](#graduation-criteria)
1923
- [Alpha](#alpha)
2024
- [Alpha -> Beta Graduation](#alpha---beta-graduation)
@@ -333,6 +337,70 @@ Beta:
333337
GA:
334338
* e2e test with an external implementation (e.g. [GCR](https://github.com/kubernetes/cloud-provider-gcp/tree/master/cmd/auth-provider-gcp)).
335339

340+
[X] I/we understand the owners of the involved components may require updates to
341+
existing tests to make this code solid enough prior to committing the changes necessary
342+
to implement this enhancement.
343+
344+
##### Prerequisite testing updates
345+
346+
<!--
347+
Based on reviewers feedback describe what additional tests need to be added prior
348+
implementing this enhancement to ensure the enhancements have also solid foundations.
349+
-->
350+
351+
N/A
352+
353+
##### Unit tests
354+
355+
<!--
356+
In principle every added code should have complete unit test coverage, so providing
357+
the exact set of tests will not bring additional value.
358+
However, if complete unit test coverage is not possible, explain the reason of it
359+
together with explanation why this is acceptable.
360+
-->
361+
362+
<!--
363+
Additionally, for Alpha try to enumerate the core package you will be touching
364+
to implement this enhancement and provide the current unit coverage for those
365+
in the form of:
366+
- <package>: <date> - <current test coverage>
367+
The data can be easily read from:
368+
https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-unit
369+
This can inform certain test coverage improvements that we want to do before
370+
extending the production code to implement this enhancement.
371+
-->
372+
373+
The unit test coverage is in k8s.io/kubernetes/pkg/credentialprovider package:
374+
375+
- k8s.io/kubernetes/pkg/credentialprovider: 06/21/2022 - 47.2
376+
377+
##### Integration tests
378+
379+
<!--
380+
This question should be filled when targeting a release.
381+
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
382+
For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
383+
https://storage.googleapis.com/k8s-triage/index.html
384+
-->
385+
386+
Please see below under e2e tests.
387+
388+
##### e2e tests
389+
390+
<!--
391+
This question should be filled when targeting a release.
392+
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
393+
For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
394+
https://storage.googleapis.com/k8s-triage/index.html
395+
We expect no non-infra related flakes in the last month as a GA graduation criteria.
396+
-->
397+
398+
An e2e test using a mock credential provider has been added for Beta launch:
399+
400+
- test/e2e_node/image_credential_provider.go: https://testgrid.k8s.io/sig-node-kubelet#kubelet-credential-provider
401+
402+
For GA launch, we will add an e2e test that utilizes the GCP credential provider (https://github.com/kubernetes/cloud-provider-gcp).
403+
336404
### Graduation Criteria
337405

338406
### Alpha

keps/sig-node/2133-kubelet-credential-providers/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ replaces:
2323
- "/keps/sig-cloud-provider/20191004-out-of-tree-credential-providers.md"
2424

2525
# The target maturity stage in the current dev cycle for this KEP.
26-
stage: beta
26+
stage: stable
2727

2828
# The most recent milestone for which work toward delivery of this KEP has been
2929
# done. This can be the current (upcoming) milestone, if it is being actively

0 commit comments

Comments
 (0)