Skip to content

Commit 9c178ec

Browse files
update test grid for api
1 parent 5028ead commit 9c178ec

File tree

1 file changed

+6
-6
lines changed
  • keps/sig-architecture/4330-compatibility-versions

1 file changed

+6
-6
lines changed

keps/sig-architecture/4330-compatibility-versions/README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,8 @@ is added in 1.29, the feature developer is expected to gate the functionality by
331331
E.g.:
332332
333333
```go
334-
if feature_gate.Enabled(FeatureA) && feature_gate.StabilityVersion(FeatureA) == "1.28" {implementation 1}
335-
if feature_gate.Enabled(FeatureA) && feature_gate.StabilityVersion(FeatureA) == "1.29" {implementation 2}
334+
if feature_gate.Enabled(FeatureA) && feature_gate.CompatibilityVersion() <= "1.28" {implementation 1}
335+
if feature_gate.Enabled(FeatureA) && feature_gate.CompatibilityVersion() >= "1.29" {implementation 2}
336336
```
337337
338338
### CEL Environment Compatibility Versioning
@@ -529,10 +529,10 @@ Alpha feature introduced|-|off-by-default|feature does not exist, feature gate m
529529
Alpha feature graduated to Beta|off-by-default|on-by-default|feature enabled only when `--feature-gates=<feature>=true`|feature enabled unless `--feature-gates=<feature>=false`
530530
Beta feature graduated to GA|on-by-default|on|feature enabled unless `--feature-gates=<feature>=false`|feature always enabled, feature gate may not be set
531531
Beta feature removed|on-by-default|-|feature enabled unless `--feature-gates=<feature>=false`|feature does not exist
532-
Alpha API introduced|-|off-by-default|feature does not exist, feature gate may not be set|API available only when `--runtime-config=api/<api>=true`
533-
Beta API graduated to GA|off-by-default|on|API available only when `--runtime-config=api/<api>=true`|API available
534-
Beta API removed|off-by-default|-|API available only when `--runtime-config=api/<api>=true`|API does not exist
535-
on-by-default Beta API removed|on-by-default|-|API available unless `--runtime-config=api/<api>=false`|API does not exist
532+
Alpha API introduced|-|off-by-default|API does not exist|API available only when `--runtime-config=api/v1alpha1=true`
533+
Beta API graduated to GA|off-by-default|on|API available only when `--runtime-config=api/v1beta1=true`|API `api/v1` available
534+
Beta API removed|off-by-default|-|API available only when `--runtime-config=api/v1beta1=true`|API `api/v1beta1` does not exist
535+
on-by-default Beta API removed|on-by-default|-|API available unless `--runtime-config=api/v1beta1=false`|API `api/v1beta1` does not exist
536536
API Storage version changed|v1beta1|v1|Resources stored as v1beta1|Resources stored as v1
537537
new CEL function|-|function in StoredExpressions CEL environment|CEL function does not exist|Resources already containing CEL expression can be evaluated
538538
introduced CEL function|function in StoredExpressions CEL environment|function in NewExpressions CEL environment|Resources already containing CEL expression can be evaluated|CEL expression can be written to resources and can be evaluted from storage

0 commit comments

Comments
 (0)