Skip to content

Commit 9d12734

Browse files
authored
Merge pull request kubernetes#2825 from dashpole/update_tracing_test
KEP-647: Change apiserver tracing to use an integration, rather than e2e test
2 parents b07ea17 + 9b592b7 commit 9d12734

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

keps/sig-instrumentation/647-apiserver-tracing/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,14 +162,16 @@ As the community found in the [Metrics Stability Framework KEP](https://github.c
162162

163163
### Test Plan
164164

165-
We will e2e test this feature by deploying an OpenTelemetry Collector on the control-plane node, and configure it to export traces using the [stdout exporter](https://github.com/open-telemetry/opentelemetry-go/tree/master/exporters/stdout), which logs the spans in json format. We can then verify that the logs contain our expected traces when making calls to the API Server.
165+
We will test tracing added by this feature with an integration test. The
166+
integration test will verify that spans exported by the apiserver match what is
167+
expected from the request.
166168

167169
## Graduation requirements
168170

169171
Alpha
170172

171173
- [] Implement tracing of incoming and outgoing http/grpc requests in the kube-apiserver
172-
- [] Tests are in testgrid and linked in KEP
174+
- [] Integration testing of tracing
173175

174176
Beta
175177

@@ -181,8 +183,6 @@ Beta
181183

182184
GA
183185

184-
- [] Tracing e2e tests are promoted to conformance tests
185-
186186
## Production Readiness Review Questionnaire
187187

188188
### Feature Enablement and Rollback

keps/sig-instrumentation/647-apiserver-tracing/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ prr-approvers:
2222
see-also:
2323
replaces:
2424
stage: alpha
25-
last-updated: 2020-10-14
25+
last-updated: 2021-07-15
2626
latest-milestone: "v1.22"
2727
milestone:
2828
alpha: "v1.22"

0 commit comments

Comments
 (0)