Skip to content

Commit 9d345c9

Browse files
committed
use a feature gate instead of a sole flag.
1 parent 742c0d7 commit 9d345c9

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

keps/sig-cloud-provider/2436-controller-manager-leader-migration/README.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,8 @@ controllerLeaders:
242242
component: kube-controller-manager
243243
```
244244
245-
First, within 1.21 control plane, update the `kube-controller-manager` to set `--enable-leader-migration` but
245+
First, within 1.21 control plane, update the `kube-controller-manager` to set `--enable-leader-migration`
246+
and `--feature-gate=ControllerManagerLeaderMigration` (this enables `ControllerManagerLeaderMigration` feature gate) but
246247
not `--leader-migration-config`, this flag enables Leader Migration with default configuration, which prepares KCM to
247248
participate in the migration.
248249

@@ -333,10 +334,9 @@ Version skew is handled as long as the leader name is consistent across all cont
333334

334335
###### How can this feature be enabled / disabled in a live cluster?
335336

336-
- [X] Other
337-
- Describe the mechanism: this feature must be explicitly enabled by `--enable-leader-migration` flag
338-
- Will enabling / disabling the feature require downtime of the control plane? No
339-
- Will enabling / disabling the feature require downtime or re-provisioning of a node? No
337+
- [X] Feature gate (also fill in values in `kep.yaml`)
338+
- Feature gate name: `ControllerManagerLeaderMigration`
339+
- Components depending on the feature gate: `cloud-controller-manager` and `kube-controller-manager`
340340

341341
###### Does enabling the feature change any default behavior?
342342

@@ -345,7 +345,8 @@ feature without providing a configuration, the default configuration will reflec
345345

346346
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
347347

348-
No. The feature is enabled and disabled solely with a flag
348+
Yes. Once the feature is enabled via feature gate, it can be disabled by unsetting `--enable-leader-migration` on KCM
349+
and CCM.
349350

350351
###### Are there any tests for feature enablement/disablement?
351352

keps/sig-cloud-provider/2436-controller-manager-leader-migration/kep.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,12 @@ milestone:
3535

3636
# The following PRR answers are required at alpha release
3737
# List the feature gate name and the components for which it must be enabled
38-
feature-gates: []
39-
disable-supported: false
38+
feature-gates:
39+
- name: ControllerManagerLeaderMigration
40+
components:
41+
- cloud-controller-manager
42+
- kube-controller-manager
43+
disable-supported: true
4044

4145
# The following PRR answers are required at beta release
4246
metrics: []

0 commit comments

Comments
 (0)