api: validate status and stage

Author: spiffxp

api/proposal.go

@@ -259,6 +259,12 @@ func (k *KEPHandler) Validate(p *Proposal) []error {
 	if errs := k.validatePRRApprovers(p); errs != nil {
 		allErrs = append(allErrs, errs...)
 	}
+	if err := p.Status.IsValid(); err != nil {
+		allErrs = append(allErrs, err)
+	}
+	if err := p.Stage.IsValid(); err != nil {
+		allErrs = append(allErrs, err)
+	}
 	return allErrs
 }
 

pkg/repo/repo_test.go

@@ -94,6 +94,20 @@ func TestProposalValidate(t *testing.T) {
 				fmt.Errorf("invalid prr-approver: not-a-prr-approver"),
 			},
 		},
+		{
+			name: "invalid KEP: status does not exist",
+			file: "testdata/invalid-status.yaml",
+			errs: []error{
+				fmt.Errorf("invalid status: monkeys, should be one of %v", api.ValidStatuses),
+			},
+		},
+		{
+			name: "invalid KEP: stage does not exist",
+			file: "testdata/invalid-stage.yaml",
+			errs: []error{
+				fmt.Errorf("invalid stage: monkeys, should be one of %v", api.ValidStages),
+			},
+		},
 	}
 
 	parser := api.KEPHandler{}

pkg/repo/testdata/invalid-owning-sig.yaml

@@ -1,18 +1,10 @@
-title: Hierarchical Namespace Controller As A Subproject
-kep-number: 1687
+title: does-not-matter
+kep-number: 1234
 authors:
-  - "@rjbez17"
-  - "@adrianludwin"
+  - "@alice"
+  - "@beth"
 owning-sig: not-a-sig
-participating-sigs:
-  - sig-auth
-reviewers:
-  - "TBD"
 approvers:
-  - "@mikedanese"
-  - "@deads2k"
-  - "@liggitt"
-creation-date: 2020-04-14
-last-updated: 2020-04-15
-stage: "alpha"
+  - "@dorothy"
 status: provisional
+stage: beta

pkg/repo/testdata/invalid-prr-approver.yaml

@@ -1,20 +1,12 @@
-title: Hierarchical Namespace Controller As A Subproject
-kep-number: 1687
+title: whatever
+kep-number: 4321
 authors:
-  - "@rjbez17"
-  - "@adrianludwin"
-owning-sig: sig-architecture
-participating-sigs:
-  - sig-auth
-reviewers:
-  - "TBD"
-approvers:
-  - "@mikedanese"
-  - "@deads2k"
-  - "@liggitt"
+  - "@alice"
+  - "@beth"
+owning-sig: sig-api-machinery
 prr-approvers:
   - not-a-prr-approver
-creation-date: 2020-04-14
-last-updated: 2020-04-15
-stage: "alpha"
+approvers:
+  - "@dorothy"
 status: provisional
+stage: beta

pkg/repo/testdata/invalid-stage.yaml

@@ -0,0 +1,10 @@
+title: i like monkeys
+kep-number: 2345
+authors:
+  - "@alice"
+  - "@beth"
+owning-sig: sig-api-machinery
+approvers:
+  - "@dorothy"
+status: provisional
+stage: monkeys

pkg/repo/testdata/invalid-status.yaml

@@ -0,0 +1,10 @@
+title: i like monkeys
+kep-number: 2345
+authors:
+  - "@alice"
+  - "@beth"
+owning-sig: sig-api-machinery
+approvers:
+  - "@dorothy"
+status: monkeys
+stage: beta

pkg/repo/testdata/valid-kep-minimum.yaml

@@ -4,20 +4,7 @@ authors:
   - "@alice"
   - "@beth"
 owning-sig: sig-api-machinery
-participating-sigs:
-  - sig-api-machinery
-  - sig-architecture
-reviewers:
-  - "@carol"
 approvers:
   - "@dorothy"
-creation-date: 2018-04-15
-last-updated: 2018-04-24
 status: provisional
-
 stage: beta
-latest-milestone: "v1.19"
-milestone:
-  alpha: "v1.19"
-  beta: "v1.20"
-  stable: "v1.22"