Skip to content

Commit 9f2b0ed

Browse files
committed
add more detail about alternatives
Signed-off-by: kerthcet <[email protected]>
1 parent 69ed2f4 commit 9f2b0ed

File tree

1 file changed

+9
-6
lines changed
  • keps/sig-scheduling/3094-pod-topology-spread-considering-taints

1 file changed

+9
-6
lines changed

keps/sig-scheduling/3094-pod-topology-spread-considering-taints/README.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ Consider including folks who also work outside the SIG or subproject.
260260
-->
261261
- Checking nodeAffinity and nodeTaints the same time may lead to performance
262262
problem, we need to verify this by adding performance tests. If performance problem
263-
does exists, we'd like to add a node selector parser and cache the parsed object
263+
does exists, we'd like to add a toleration parser and cache the parsed object
264264
during PreFilter.
265265

266266
## Design Details
@@ -301,9 +301,9 @@ type PolicyName string
301301

302302
const (
303303
// Ignore means ignore this policy in calculating.
304-
Ignore PolicyName = "ignore"
304+
Ignore PolicyName = "Ignore"
305305
// Respect means use this policy in calculating.
306-
Respect PolicyName = "respect"
306+
Respect PolicyName = "Respect"
307307
)
308308
```
309309

@@ -531,7 +531,7 @@ feature flags will be enabled on some API servers and not others during the
531531
rollout. Similarly, consider large clusters and how enablement/disablement
532532
will rollout across nodes.
533533
-->
534-
A malformed configuration like non-exist policy will cause the scheduler failing to start. Running workloads are not affected.
534+
N/A
535535

536536
###### What specific metrics should inform a rollback?
537537

@@ -815,8 +815,11 @@ What other approaches did you consider, and why did you rule them out? These do
815815
not need to be as detailed as the proposal, but should include enough
816816
information to express the idea and why it was not acceptable.
817817
-->
818-
- Changing the current behavior without introducing control.
819-
- Checking specific taints.
818+
- The community has discussed about changing the current behavior implicitly,
819+
but considering this will introduce a break user-facing change, for backwards
820+
compatibility, we decided to add a feature as switch for end-users.
821+
- We have also discussed about whether to support specific taints, but considering
822+
there's no strong demands from end-users, we will delay this until needed.
820823

821824
## Infrastructure Needed (Optional)
822825

0 commit comments

Comments
 (0)