@@ -339,52 +339,26 @@ implementing this enhancement to ensure the enhancements have also solid foundat
339
339
340
340
##### Unit tests
341
341
342
- <!--
343
- In principle every added code should have complete unit test coverage, so providing
344
- the exact set of tests will not bring additional value.
345
- However, if complete unit test coverage is not possible, explain the reason of it
346
- together with explanation why this is acceptable.
347
- -->
348
-
349
- <!--
350
- Additionally, for Alpha try to enumerate the core package you will be touching
351
- to implement this enhancement and provide the current unit coverage for those
352
- in the form of:
353
- - <package>: <date> - <current test coverage>
354
- The data can be easily read from:
355
- https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-unit
356
-
357
- This can inform certain test coverage improvements that we want to do before
358
- extending the production code to implement this enhancement.
359
- -->
360
-
361
- - ` <package> ` : ` <date> ` - ` <test coverage> `
342
+ TBD - unit tests will be added as this feature is implemented.
362
343
363
344
##### Integration tests
364
345
365
- <!--
366
- This question should be filled when targeting a release.
367
- For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
368
-
369
- For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
370
- https://storage.googleapis.com/k8s-triage/index.html
371
- -->
346
+ Test cases to add:
372
347
373
- - <test >: <link to test coverage >
348
+ - [ ] Feature gate enablement / disablement is a no-op when no ` matchConditions ` are set
349
+ - [ ] Feature gate enablement / disablement works as expected when ` matchConditions ` are set
350
+ - [ ] Single match condition:
351
+ - [ ] Request out of scope without ` matchConditions `
352
+ - [ ] Request in scope without ` matchConditions ` , but not matching
353
+ - [ ] Request in scope without ` matchConditions ` , and also matching
354
+ - [ ] Multiple match conditions, covering the same cases as the single-condition case
374
355
375
356
##### e2e tests
376
357
377
- <!--
378
- This question should be filled when targeting a release.
379
- For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
380
-
381
- For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
382
- https://storage.googleapis.com/k8s-triage/index.html
383
-
384
- We expect no non-infra related flakes in the last month as a GA graduation criteria.
385
- -->
358
+ We will test the edge cases mostly in integration tests and unit tests.
386
359
387
- - <test >: <link to test coverage >
360
+ Once the feature graduates to GA, a single E2E test covering hte single-match-condition cases
361
+ outlined above will be added.
388
362
389
363
### Graduation Criteria
390
364
0 commit comments