Skip to content

Commit a462ca3

Browse files
author
Ricardo Katz
committed
Add manual tests on upgrade/downgrade of the feature
1 parent 03e7c9b commit a462ca3

File tree

1 file changed

+14
-1
lines changed
  • keps/sig-network/2079-network-policy-port-range

1 file changed

+14
-1
lines changed

keps/sig-network/2079-network-policy-port-range/README.md

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,20 @@ start working incorrectly. This is a fail-closed failure, so it is acceptable.
291291
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
292292

293293
Yes, with unit tests.
294-
There's still some need to make manual tests, that will be done in a follow up.
294+
Manual tests were also executed as the following:
295+
* Created a KinD cluster in v1.24 and Calico as a CNI
296+
* Created a Network Policy with `endPort` field to allow a Pod egress to ports from 70 to 90
297+
* Did a test against a target in port 80 - Worked
298+
* Disabled the Feature Gate
299+
* The Network Policy still worked fine
300+
* Changed the Network Policy so the range is 70 to 79, and the Network Policy was changed fine
301+
* Traffic started to be blocked, but could call port 78 as it is still within range
302+
* Removed `endPort` field, and wasn't able to re-add it as Feature gate was disabled
303+
* Re-enabled feature gate
304+
* Re-added `endPort` field with value of 90
305+
* Traffic started to flow/be accepted again
306+
307+
Per the manual tests, all worked as desired.
295308

296309
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
297310

0 commit comments

Comments
 (0)