Skip to content

Commit a500df8

Browse files
authored
Merge pull request kubernetes#2612 from logicalhan/stability-ga
update status on metric stability framework
2 parents a7f3ac1 + 5ef2665 commit a500df8

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

keps/sig-instrumentation/1209-metrics-stability/README.md

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
- [How does this feature react if the API server and/or etcd is unavailable?](#how-does-this-feature-react-if-the-api-server-andor-etcd-is-unavailable)
2828
- [What are other known failure modes?](#what-are-other-known-failure-modes)
2929
- [Implementation History](#implementation-history)
30+
- [Current list of stable metrics:](#current-list-of-stable-metrics)
3031
<!-- /toc -->
3132

3233
## Release Signoff Checklist
@@ -222,13 +223,19 @@ At worst, this thing can clog the commit pipeline (since it is effectively a con
222223

223224
## Implementation History
224225

225-
See:
226-
227226
1. [Metrics Stability Framework#Implementation History]
228227
1. [Metrics Stability Migration#Implementation History]
229228
1. [Metrics Validation and Verification#Implementation History]
230229
1. [Metrics Stability to Beta#Implementation History]
231230

231+
Status: currently implemented.
232+
233+
### Current list of stable metrics:
234+
235+
1. [apiserver_request_total](https://github.com/kubernetes/kubernetes/pull/99788)
236+
2. [apiserver_storage_object_counts](https://github.com/kubernetes/kubernetes/pull/99785)
237+
3. [apiserver_request_duration_seconds](https://github.com/kubernetes/kubernetes/pull/99925)
238+
232239
[Metrics Stability Framework#Implementation History]: kubernetes-control-plane-metrics-stability.md#implementation-history
233240
[Metrics Stability Migration#Implementation History]: metrics-stability-migration.md#implementation-history
234241
[Metrics Validation and Verification#Implementation History]: metrics-validation-and-verification.md#implementation-history

keps/sig-instrumentation/1209-metrics-stability/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ participating-sigs:
1313
- sig-cluster-lifecycle
1414
- sig-cloud-provider
1515
- sig-testing
16-
status: implementable
16+
status: implemented
1717
creation-date: 2019-04-04
1818
reviewers:
1919
- "@brancz" # instrumentation

keps/sig-instrumentation/1209-metrics-stability/kubernetes-control-plane-metrics-stability.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,7 @@ Metrics which are added dynamically after application boot - Metrics which are d
321321
- Wrappers added around prometheus registry and counter/counterVec metric type [PR-77037](https://github.com/kubernetes/kubernetes/pull/77037)
322322
- Wrappers added around prometheus gauge, histogram & summary metric types [PR-77618](https://github.com/kubernetes/kubernetes/pull/77618)
323323
- Make sig-instrumentation owners for component-base metrics directory [PR-77621](https://github.com/kubernetes/kubernetes/pull/77621)
324+
- [Allow explicit disabling of metrics as an escape hatch](https://github.com/kubernetes/kubernetes/pull/99217)
324325
325326
## References
326327

0 commit comments

Comments
 (0)