Skip to content

Commit ac49124

Browse files
authored
Merge pull request kubernetes#3393 from liggitt/2799
KEP-2799: Update for 1.25
2 parents e551f3d + 40a6022 commit ac49124

File tree

2 files changed

+32
-17
lines changed

2 files changed

+32
-17
lines changed

keps/sig-auth/2799-reduction-of-secret-based-service-account-token/README.md

Lines changed: 28 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# KEP-2799: Reduction of Secret-based Service Account Tokens
22

33
<!-- toc -->
4-
54
- [Release Signoff Checklist](#release-signoff-checklist)
65
- [Summary](#summary)
76
- [Motivation](#motivation)
@@ -16,6 +15,10 @@
1615
- [LegacyServiceAccountTokenTracking](#legacyserviceaccounttokentracking)
1716
- [LegacyServiceAccountTokenCleanUp](#legacyserviceaccounttokencleanup)
1817
- [Test Plan](#test-plan)
18+
- [Prerequisite testing updates](#prerequisite-testing-updates)
19+
- [Unit tests](#unit-tests)
20+
- [Integration tests](#integration-tests)
21+
- [e2e tests](#e2e-tests)
1922
- [Graduation Criteria](#graduation-criteria)
2023
- [LegacyServiceAccountTokenNoAutoGeneration](#legacyserviceaccounttokennoautogeneration-1)
2124
- [Beta -&gt; GA Graduation](#beta---ga-graduation)
@@ -165,16 +168,30 @@ If `tracked-since` is unavailable, no secret would be removed.
165168

166169
### Test Plan
167170

168-
- Unit tests
169-
- Integration tests
170-
- Previously auto-generated secret-based token that's used within the
171-
configurable cleanup duration will continue to work.
172-
- Previously auto-generated secret-based token that's used after the
173-
configurable cleanup duration will be deleted.
174-
- E2E tests
175-
- Secret-based tokens would not be auto-generated.
176-
- Still able to explicitly request a secret-based token.
177-
- The explicitly requested token would not be deleted.
171+
[X] I/we understand the owners of the involved components may require updates to
172+
existing tests to make this code solid enough prior to committing the changes necessary
173+
to implement this enhancement.
174+
175+
##### Prerequisite testing updates
176+
177+
None
178+
179+
##### Unit tests
180+
181+
- `k8s.io/kubernetes/pkg/controller/serviceaccount`: `2022-06-13` - `67.5%`
182+
183+
##### Integration tests
184+
185+
- Previously auto-generated secret-based token that's used within the
186+
configurable cleanup duration will continue to work.
187+
- Previously auto-generated secret-based token that's used after the
188+
configurable cleanup duration will be deleted.
189+
190+
##### e2e tests
191+
192+
- Secret-based tokens would not be auto-generated.
193+
- Still able to explicitly request a secret-based token.
194+
- The explicitly requested token would not be deleted.
178195

179196
### Graduation Criteria
180197

keps/sig-auth/2799-reduction-of-secret-based-service-account-token/kep.yaml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,16 @@ participating-sigs:
77
- sig-auth
88
status: implementable
99
creation-date: 2021-06-25
10-
last-updated: 2022-01-26
1110
reviewers:
1211
- "@liggitt"
1312
- "@mikedanese"
1413
approvers:
1514
- "@liggitt"
16-
prr-approvers:
17-
- TBD
18-
stage: alpha
19-
latest-milestone: "v1.24"
15+
stage: beta
16+
latest-milestone: "v1.25"
2017
milestone:
2118
alpha: "v1.24"
19+
beta: "v1.25"
2220
feature-gates:
2321
- name: LegacyServiceAccountTokenNoAutoGeneration
2422
components:
@@ -31,4 +29,4 @@ feature-gates:
3129
- kube-controller-manager
3230
disable-supported: true
3331
metrics:
34-
- TBD
32+
- serviceaccount_legacy_tokens_total

0 commit comments

Comments
 (0)