Skip to content

Commit b774aba

Browse files
committed
Update gce-pd csi migration test plan
1 parent 5cde0fc commit b774aba

File tree

2 files changed

+41
-3
lines changed

2 files changed

+41
-3
lines changed

keps/sig-storage/1488-csi-migration-gce-pd/README.md

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@
66
- [Summary](#summary)
77
- [New Feature Gates](#new-feature-gates)
88
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
9+
- [Design Details](#design-details)
10+
- [Test Plan](#test-plan)
11+
- [Prerequisite testing updates](#prerequisite-testing-updates)
12+
- [Unit tests](#unit-tests)
13+
- [Integration tests](#integration-tests)
14+
- [e2e tests](#e2e-tests)
915
- [Implementation History](#implementation-history)
1016
<!-- /toc -->
1117

@@ -40,6 +46,40 @@ used as as described in its parent KEP. For all other contents, please refer to
4046

4147
Please refer to the [CSI Migration Production Readiness Review Questionnaire](https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/625-csi-migration#production-readiness-review-questionnaire).
4248

49+
## Design Details
50+
51+
### Test Plan
52+
53+
[X] I/we understand the owners of the involved components may require updates to
54+
existing tests to make this code solid enough prior to committing the changes necessary
55+
to implement this enhancement.
56+
57+
##### Prerequisite testing updates
58+
59+
No additional tests are needed, rather the issue is orchestrating CSI driver
60+
deployment for prow jobs. This has been complicated by the cloud provider
61+
extraction work, which no longer permits cloud provider specific orchestration
62+
in the k/k repository. This means that it is not possible to run any test for
63+
gce-pd in k/k. All such tests have been moved to the [cloud-provider-gcp repo and
64+
test infrastructure](https://github.com/kubernetes/cloud-provider-gcp).
65+
66+
##### Unit tests
67+
68+
See tests in [`k8s.io/csi-translation-lib/plugins/gce_pd_test`](https://github.com/kubernetes/csi-translation-lib/blob/master/plugins/gce_pd_test.go).
69+
70+
##### Integration tests
71+
72+
N/A
73+
74+
##### e2e tests
75+
76+
Support for tests after gce-pd migration have been [added to
77+
cloud-provider-gcp](https://github.com/kubernetes/cloud-provider-gcp/pull/265). These
78+
tests [have been removed from the k/k test
79+
jobs](https://github.com/kubernetes/test-infra/pulls?q=is%3Apr+author%3Aleiyiz+gcepd).
80+
81+
The e2e tests are now covered in [cloud-provider-gcp](https://testgrid.k8s.io/provider-gcp-presubmits#cloud-provider-gcp-e2e-full&include-filter-by-regex=gcepd).
82+
4383
## Implementation History
4484

4585
Major milestones in the life cycle of a KEP should be tracked in `Implementation History`.

keps/sig-storage/1488-csi-migration-gce-pd/kep.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ disable-supported: true
1818
status: implementable
1919
see-also:
2020
- "https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md"
21-
prr-approvers:
22-
- "@wojtek-t"
2321
replaces:
2422

2523
# The target maturity stage in the current dev cycle for this KEP.
@@ -53,4 +51,4 @@ feature-gates:
5351
# The following PRR answers are required at beta release
5452
metrics:
5553
- csi_sidecar_duration_operation
56-
- storage_operation_duration_seconds
54+
- storage_operation_duration_seconds

0 commit comments

Comments
 (0)