Skip to content

Commit c08afd7

Browse files
committed
Clarify unresolved issues in KEP
1 parent 0561b82 commit c08afd7

File tree

1 file changed

+9
-4
lines changed
  • keps/sig-api-machinery/2144-clientgo-apply

1 file changed

+9
-4
lines changed

keps/sig-api-machinery/2144-clientgo-apply/README.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,10 +201,11 @@ fields are a good example of fields that would be applied incorrectly using go
201201
structs, e.g. `ContainerStatus.Ready` (required, not omitempty). Because of this
202202
we cannot use the existing go structs to represent apply configurations.
203203

204-
<<[UNRESOLVED @jpbetz @jennybuckley ]>>
205-
We also considered quite a few alternate representations for how apply
206-
configurations will be represented in go. See the [Alternatives](#alternatives)
207-
for a complete list. We are currently evaluating two leading alternatives:
204+
<<[UNRESOLVED @jpbetz @jennybuckley ]>>
205+
Finalize which alternative to use based on developer feedback. See the
206+
[Alternatives](#alternatives) for a complete list, but are currently focusing on
207+
the two below alternatives. We are working with the Kubebuilder community to
208+
gather feedback on what developers prefer.
208209
<<[/UNRESOLVED]>>
209210

210211
#### Alternative 1: Genreated structs where all fields are pointers
@@ -262,6 +263,10 @@ Example usage:
262263

263264
#### Comparison of alternatives
264265

266+
See https://github.com/kubernetes/kubernetes/pull/95988 for a working implementation
267+
of alterative 1 and https://github.com/jpbetz/kubernetes/tree/apply-client-go-builders
268+
for a working implementation of alternative 2.
269+
265270
Of the two leading alternatives--"builders" and "structs with pointers"--we implemented
266271
prototypes of both. They had roughly equivalent performance, and no differences
267272
in their capabilities. The choice between the two is primarily one of asthetics/ergonomics.

0 commit comments

Comments
 (0)