Skip to content

Commit c0d4951

Browse files
authored
Merge pull request kubernetes#3596 from logicalhan/amend-slis
amend test section for component slis
2 parents e79a886 + 8050b75 commit c0d4951

File tree

1 file changed

+4
-3
lines changed
  • keps/sig-instrumentation/3466-kubernetes-component-health-slis

1 file changed

+4
-3
lines changed

keps/sig-instrumentation/3466-kubernetes-component-health-slis/README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -250,13 +250,13 @@ without any issues.
250250

251251
##### Integration tests
252252

253-
- [ ] ensure existence of healthcheck endpoint
253+
- [ ] ensure existence of healthcheck endpoint (beta requirement)
254254

255255
- <test>: <link to test coverage>
256256

257257
##### e2e tests
258258

259-
- [ ] ensure existence of healthcheck endpoint
259+
- [ ] ensure existence of healthcheck endpoint (beta requirement)
260260

261261
- <test>: <link to test coverage>
262262

@@ -295,11 +295,12 @@ Below are some examples to consider, in addition to the aforementioned [maturity
295295
#### Alpha
296296

297297
- Feature implemented behind a feature flag
298-
- Initial e2e tests completed and enabled
299298
- Feature implemented for apiserver
299+
- unit tests covering aspects of the feature
300300

301301
#### Beta
302302

303+
- e2e tests completed and enabled (this needs to be beta due to feature flag enablement)
303304
- Gather feedback from developers
304305
- Feature implemented for other Kubernetes Components
305306

0 commit comments

Comments
 (0)