Skip to content

Commit c797607

Browse files
committed
Update PRR section
1 parent 5f65aa2 commit c797607

File tree

1 file changed

+8
-6
lines changed
  • keps/sig-storage/1790-recover-resize-failure

1 file changed

+8
-6
lines changed

keps/sig-storage/1790-recover-resize-failure/README.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -198,17 +198,19 @@ If CSI driver does not have `GET_VOLUME` controller capability(or `ControllerGet
198198

199199
* **Can the feature be disabled once it has been enabled (i.e. can we rollback
200200
the enablement)?**
201-
Yes the feature gate can be disabled once enabled. The quota code will use new field to calculate quota if available. This will allow quota code to use
202-
`pvc.Status.AllocatedResources` even if feature gate is disabled.
201+
Yes the feature gate can be disabled once enabled. However quota resources present in the cluster will be based off a field(`pvc.Status.AllocatedResources`) which is no longer updated.
202+
Currently without this feature - quota calculation is entirely based on `pvc.Spec.Resources` and when feature is enabled it will based off `max(pvc.Spec.Resources, pvc.Status.AllocatedResources)`
203+
so when the feature is disabled, cluster might be reporting stale quota.
203204

204205
* **What happens if we reenable the feature if it was previously rolled back?**
205-
This KEP proposes a new field in pvc and it will be used if available for quota calculation. So when feature is rolled back, it will be possible to reduce pvc capacity and quota will use `pvc.Status.AllocatedResources`.
206+
It should be possible to re-enable the feature after disabling it. When feature is disabled and re-enabled, users will be able to
207+
reduce size of `pvc.Spec.Resources` to cancel previously issued expansion but in case `pvc.Spec.Resources` reports lower value than
208+
what was reported in `pvc.Status.AllocatedResources` (which would mean resize controller tried to expand this volume to bigger size previously)
209+
quota calculation will be based off `pvc.Status.AllocatedResources`.
206210

207211
* **Are there any tests for feature enablement/disablement?**
208212
The e2e framework does not currently support enabling and disabling feature
209-
gates. However, unit tests in each component dealing with managing data created
210-
with and without the feature are necessary. At the very least, think about
211-
conversion tests if API types are being modified.
213+
gates. However, we will write extensive unit tests to test behaviour of code when feature gate is disabled and when feature gate is enabled.
212214

213215
### Rollout, Upgrade and Rollback Planning
214216

0 commit comments

Comments
 (0)