Skip to content

Commit c9c80fd

Browse files
authored
Merge pull request kubernetes#3583 from aojea/ga_service_iprange
promote ServiceIPStaticSubrange to GA
2 parents cfae5b8 + cb3de8d commit c9c80fd

File tree

3 files changed

+14
-21
lines changed

3 files changed

+14
-21
lines changed

keps/prod-readiness/sig-network/3070.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,5 @@ alpha:
33
approver: "@wojtek-t"
44
beta:
55
approver: "@johnbelamaric"
6+
stable:
7+
approver: "@wojtek-t"

keps/sig-network/3070-reserved-service-ip-range/README.md

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -358,8 +358,8 @@ This only affects the creation of new Services without an IP specified, there is
358358
359359
###### What specific metrics should inform a rollback?
360360
361-
The allocation logic already has the following metrics, that will be expanded with a new label containing information about the
362-
type of allocation requested (dynamic or static):
361+
The allocation logic already has the following metrics, [some metrics have been extended with a
362+
new label to contain information about the allocation scope requested](#monitoring-requirements):
363363
364364
- allocated_ips
365365
- available_ips
@@ -370,11 +370,12 @@ The increase of the errors metrics or the trend of the allocated_ips and availab
370370
371371
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
372372
373+
Since it is a purely in-memory feature the upgrade or downgrande doesn't have any impact.
373374
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
374375
375376
### Monitoring Requirements
376377
377-
Following allocator metrics will be expanded with a new label to each metric containing information about the
378+
Following allocator metrics have been expanded with a new label to each metric containing information about the
378379
type of allocation requested (dynamic or static):
379380
380381
- allocation_total
@@ -387,20 +388,7 @@ The other allocator the metrics can not use the additional label because, when a
387388
388389
###### How can an operator determine if the feature is in use by workloads?
389390
390-
A new metric will be added containing the information of the range configuration in the allocator.
391-
392-
```go
393-
allocatorInfo = metrics.NewGaugeVec(
394-
&metrics.GaugeOpts{
395-
Name: "allocator_info",
396-
Help: "A metric with a constant '1' value labeled by Service CIDR, ",
397-
StabilityLevel: metrics.ALPHA,
398-
},
399-
[]string{"cidr", "allocator_size", "dynamic_range_offset"},
400-
)
401-
```
402-
403-
The allocator using this feature will have a `dynamic_range_offset` value different than 0.
391+
An operator will only observe that the change in behavior described for dynamically assigned ClusterIP for Services.
404392
405393
###### How can someone using this feature know that it is working for their instance?
406394
@@ -409,14 +397,14 @@ The allocator using this feature will have a `dynamic_range_offset` value differ
409397
- [ ] API .status
410398
- Condition name:
411399
- Other field:
412-
- [ ] Other (treat as last resort)
400+
- [X] Other (treat as last resort)
413401
- Details:
414402
- Create services without setting the ClusterIP and observe that all the services IPs allocated belong the upper band of the range,
415403
and once the upper band is exhausted it keep assigning IPs on the lower band until the whole range is exhausted.
416404
417405
###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?
418406
419-
407+
N/A
420408
###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?
421409
422410
@@ -429,6 +417,9 @@ The allocator using this feature will have a `dynamic_range_offset` value differ
429417
430418
###### Are there any missing metrics that would be useful to have to improve observability of this feature?
431419
420+
We could have a metric exposing the configuration parameters of the allocator, but that will collide
421+
and is incompatible with a new KEP that expand the Service allocators to make the dynamically configurable.
422+
432423
### Dependencies
433424
434425
###### Does this feature depend on any specific services running in the cluster?

keps/sig-network/3070-reserved-service-ip-range/kep.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ approvers:
1414
- "@danwinship"
1515

1616
# The target maturity stage in the current dev cycle for this KEP.
17-
stage: beta
17+
stage: stable
1818

1919
# The most recent milestone for which work toward delivery of this KEP has been
2020
# done. This can be the current (upcoming) milestone, if it is being actively
2121
# worked on.
22-
latest-milestone: "v1.25"
22+
latest-milestone: "v1.26"
2323

2424
# The milestone at which this feature was, or is targeted to be, at each stage.
2525
milestone:

0 commit comments

Comments
 (0)