Skip to content

Commit cf61166

Browse files
committed
Address comments
Signed-off-by: Mrunal Patel <[email protected]>
1 parent fb4773f commit cf61166

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

keps/sig-node/2254-cgroup-v2/README.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ yes, it is enough to restart the node on cgroup v1
132132

133133
###### What happens if we reenable the feature if it was previously rolled back?
134134

135-
it should work seamlessly without any difference
135+
It should work seamlessly without any difference
136136

137137
###### Are there any tests for feature enablement/disablement?
138138

@@ -149,7 +149,8 @@ cgroup file system, then also the workload must be enabled for cgroup v2.
149149

150150
###### What specific metrics should inform a rollback?
151151

152-
Pods not being healthy.
152+
Pods not being healthy. One could inspect if the pods are getting the cgroups
153+
set correctly referencing the conversion table in this KEP.
153154

154155
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
155156

@@ -163,8 +164,8 @@ The cgroup file system inside of the containers will use cgroup v2 instead of cg
163164

164165
###### How can an operator determine if the feature is in use by workloads?
165166

166-
Looking at the node configuration. If the node is using cgroup v2, then also the pods
167-
running on that node are using it.
167+
An operator could run `cat /proc/self/cgroup` on a node to check if it is running in cgroups v2 mode.
168+
If the node is using cgroup v2, then also the pods running on that node are using it.
168169

169170
###### How can someone using this feature know that it is working for their instance?
170171

@@ -192,7 +193,7 @@ N/A. Same as when running on cgroup v1.
192193

193194
###### Are there any missing metrics that would be useful to have to improve observability of this feature?
194195

195-
N.
196+
No
196197

197198
### Dependencies
198199

@@ -240,7 +241,7 @@ N/A
240241

241242
###### What steps should be taken if SLOs are not being met to determine the problem?
242243

243-
Reboot the node on cgroup v1
244+
If SLOs are not being met, reboot the node in cgroup v1 to disable this feature.
244245

245246
## Proposal
246247

0 commit comments

Comments
 (0)