Skip to content

Commit d0b0458

Browse files
authored
Merge pull request kubernetes#2774 from nikhita/stop-publishing-godeps
Update go modules KEP to stop publishing synthetic Godeps.json files
2 parents 71cf065 + d6c05a3 commit d0b0458

File tree

1 file changed

+6
-3
lines changed
  • keps/sig-architecture/917-go-modules

1 file changed

+6
-3
lines changed

keps/sig-architecture/917-go-modules/README.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,8 @@ Update the staging component publishing bot:
132132
4. Generate synthetic `Godeps.json` files containing the SHA or git tag of module dependencies,
133133
for consumption by downstream consumers using dependency management tools like `glide`.
134134
Continue publishing these at least until our minimum supported version of go defaults to enabling
135-
module support (currently targeted for go 1.13, which is approximately Kubernetes 1.16-1.17 timeframe).
135+
module support. _Update (June 2021): Support for publishing these files was removed since Kubernetes now
136+
uses go 1.16.4 and module-aware mode is enabled by default_.
136137
137138
See the [alternatives](#alternatives-to-publishing-staging-component-modules) section for other publishing methods considered.
138139
@@ -199,8 +200,10 @@ See the [alternatives](#alternative-versioning-strategies) section for other pos
199200
* Move aggregated `Godeps/LICENSES` file to `vendor/LICENSES` (and ensure it is packaged correctly in build artifacts)
200201
* Remove `Godeps.json` files from `kubernetes/kubernetes` and staging component directories.
201202
With the change to go modules, the only use for these is as a hint to non-module-based downstream consumers of the published staging components.
202-
* Remove the custom `Godeps` fork from `kubernetes/kubernetes`
203-
* Remove all other `Godeps` references in scripts, comments, and configurations files
203+
* Remove the custom `Godeps` fork from `kubernetes/kubernetes`.
204+
* Remove all other `Godeps` references in scripts, comments, and configurations files.
205+
* _Update (June 2021)_: Remove the `Godeps` directory for all staging component directories.
206+
This completely removes Godeps from `kubernetes/kubernetes`.
204207
205208
## Design Details
206209

0 commit comments

Comments
 (0)