Skip to content

Commit d41d785

Browse files
authored
Merge pull request kubernetes#3406 from adrianreber/2022-06-17-update-test-plan
KEP 2008: update test plan
2 parents f2c3ba9 + 2ae6b4e commit d41d785

File tree

1 file changed

+72
-4
lines changed
  • keps/sig-node/2008-forensic-container-checkpointing

1 file changed

+72
-4
lines changed

keps/sig-node/2008-forensic-container-checkpointing/README.md

Lines changed: 72 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414
- [Design Details](#design-details)
1515
- [Future Enhancements](#future-enhancements)
1616
- [Test Plan](#test-plan)
17+
- [Prerequisite testing updates](#prerequisite-testing-updates)
18+
- [Unit tests](#unit-tests)
19+
- [Integration tests](#integration-tests)
20+
- [e2e tests](#e2e-tests)
1721
- [Graduation Criteria](#graduation-criteria)
1822
- [Alpha](#alpha)
1923
- [Alpha to Beta Graduation](#alpha-to-beta-graduation)
@@ -168,13 +172,77 @@ discussed in [#3949](https://github.com/kubernetes/kubernetes/issues/3949).
168172

169173
### Test Plan
170174

171-
For alpha:
172-
- Unit tests available
175+
<!--
176+
**Note:** *Not required until targeted at a release.*
177+
The goal is to ensure that we don't accept enhancements with inadequate testing.
178+
All code is expected to have adequate tests (eventually with coverage
179+
expectations). Please adhere to the [Kubernetes testing guidelines][testing-guidelines]
180+
when drafting this test plan.
181+
[testing-guidelines]: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md
182+
-->
183+
184+
[x] I/we understand the owners of the involved components may require updates to
185+
existing tests to make this code solid enough prior to committing the changes necessary
186+
to implement this enhancement.
187+
188+
##### Prerequisite testing updates
189+
190+
<!--
191+
Based on reviewers feedback describe what additional tests need to be added prior
192+
implementing this enhancement to ensure the enhancements have also solid foundations.
193+
-->
194+
195+
##### Unit tests
196+
197+
<!--
198+
In principle every added code should have complete unit test coverage, so providing
199+
the exact set of tests will not bring additional value.
200+
However, if complete unit test coverage is not possible, explain the reason of it
201+
together with explanation why this is acceptable.
202+
-->
203+
204+
<!--
205+
Additionally, for Alpha try to enumerate the core package you will be touching
206+
to implement this enhancement and provide the current unit coverage for those
207+
in the form of:
208+
- <package>: <date> - <current test coverage>
209+
The data can be easily read from:
210+
https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-unit
211+
This can inform certain test coverage improvements that we want to do before
212+
extending the production code to implement this enhancement.
213+
-->
214+
215+
- `pkg/kubelet`: 06-17-2022 - 64.5
216+
- `pkg/kubelet/container`: 06-17-2022 - 52.1
217+
- `pkg/kubelet/server`: 06-17-2022 - 64.3
218+
- `pkg/kubelet/cri/remote`: 06-17-2022 - 13.2
219+
220+
##### Integration tests
221+
222+
<!--
223+
This question should be filled when targeting a release.
224+
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
225+
For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
226+
https://storage.googleapis.com/k8s-triage/index.html
227+
-->
173228

174-
For beta:
175229
- CRI API changes need to be implemented by at least one
176230
container engine
177-
- Enable e2e testing
231+
232+
##### e2e tests
233+
234+
<!--
235+
This question should be filled when targeting a release.
236+
For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
237+
For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
238+
https://storage.googleapis.com/k8s-triage/index.html
239+
We expect no non-infra related flakes in the last month as a GA graduation criteria.
240+
-->
241+
242+
- Alpha will include e2e tests with the expectation that
243+
no CRI implementation provides the newly added RPC calls.
244+
Once CRI implementation provide the relevant RPC calls
245+
the e2e tests will not fail but need to be extended.
178246

179247
### Graduation Criteria
180248

0 commit comments

Comments
 (0)