Skip to content

Commit d8ed710

Browse files
committed
address comments
Signed-off-by: Rita Zhang <[email protected]>
1 parent a4d5483 commit d8ed710

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

keps/sig-node/5018-dra-adminaccess/README.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -255,9 +255,9 @@ restrictions when preparing the device.
255255
In Kubernetes 1.31 (before this KEP was introduced), an example validating
256256
admission policy
257257
[was provided](https://github.com/kubernetes/kubernetes/blob/4aeaf1e99e82da8334c0d6dddd848a194cd44b4f/test/e2e/dra/test-driver/deploy/example/admin-access-policy.yaml#L1-L11)
258-
which restricts access to this option. It is the responsibility of cluster
259-
admins to ensure that such a policy is installed if the cluster shouldn't allow
260-
unrestricted access.
258+
which restricted access to this option. It was formerly the responsibility of
259+
cluster admins to ensure that such a policy was installed if the cluster
260+
shouldn't have allowed unrestricted access.
261261

262262
Starting in Kubernetes 1.33 (when this KEP was introduced), a validation has
263263
been added to the REST storage layer to only authorize `ResourceClaim` or
@@ -283,10 +283,6 @@ admin namespace label.
283283

284284
### Kube-controller-manager Changes
285285

286-
In pkg/controller/resourceclaim/controller.go, process `ResourceClaim` in
287-
`syncClaim` function to check for the `adminAccess` field and the feature gate
288-
enablement to ensure the field can be set.
289-
290286
// TODO: what part of claim.Status.Allocation should be updated? e.g.
291287
AdminAccess is part of `DeviceRequestAllocationResult` but need to set it for
292288
each device?

0 commit comments

Comments
 (0)