Skip to content

Commit d917695

Browse files
committed
sidecar: Update PoC implementation note
After the last changes to the KEP, this doesn't apply anymore: the podPhase is not modified. Furthermore, the preStop hooks are sent once but the PoC wasn't updated to reflect that. To avoid confussions, call it out there. Signed-off-by: Rodrigo Campos <[email protected]>
1 parent 999fda3 commit d917695

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

keps/sig-node/0753-sidecarcontainers.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -553,8 +553,7 @@ them][kinvolk-poc-sidecar-test-commit] for instruction on how to run it.
553553
Some other things worth noting about the implementation:
554554
* It is done using pod annotations so it is easy to test for users (doesn't
555555
modify pod spec)
556-
* It implements the KEP proposal and not the suggested modifications, with one
557-
exception: the podPhase is not modified.
556+
* Wasn't updated to call preStop hooks one time only, as this KEP now proposes
558557
* There is some c&p code to avoid doing refactors and just have a patch that is
559558
simpler to cherry-pick on different Kubernetes versions.
560559

0 commit comments

Comments
 (0)