Skip to content

Commit de711ee

Browse files
committed
Apply review comments
1 parent 46219c4 commit de711ee

File tree

1 file changed

+3
-2
lines changed
  • keps/sig-scheduling/5142-pop-backoffq-when-activeq-empty

1 file changed

+3
-2
lines changed

keps/sig-scheduling/5142-pop-backoffq-when-activeq-empty/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,8 @@ since it plays also rate limiting role, avoiding system overload due to too freq
135135
At the beginning of the scheduling cycle, a pod is popped from the activeQ.
136136
Currently, when activeQ is empty, it waits until some pod is placed into the queue.
137137
This KEP proposes to pop the pod from the backoffQ when the activeQ is empty,
138-
however moving pods from the backoffQ to activeQ will still work as before to avoid the problem of pods starvation,
138+
however the current mechanism of moving pods from the backoffQ to activeQ (aka flushing)
139+
will still work as before to avoid the problem of pods starvation,
139140
which was the original reason of introducing the backoffQ.
140141

141142
To ensure the `PreEnqueue` is called for each pod taken into the scheduling cycle,
@@ -175,7 +176,7 @@ and the pod that had a smaller attempt number eventually won't be popped out.
175176

176177
### Low priority pod could be chosen to pop, even if high priority pod has a slightly later backoff expiration
177178

178-
Flushing from backoffQ to activeQ is done each second, taking all pods with backoff expired.
179+
The current mechanism of flushing from backoffQ to activeQ is done each second, taking all pods with backoff expired.
179180
It means that, when they come to activeQ, they are sorted by priority there and taken in this order from activeQ.
180181
It is important, because preemption of a lower priority pod could happen if a higher priority pod is scheduled later.
181182

0 commit comments

Comments
 (0)