Skip to content

Commit dfa580d

Browse files
committed
Fix PRR section
1 parent 4538050 commit dfa580d

File tree

2 files changed

+13
-6
lines changed
  • keps/sig-storage/3294-provision-volumes-from-cross-namespace-snapshots

2 files changed

+13
-6
lines changed

keps/sig-storage/3294-provision-volumes-from-cross-namespace-snapshots/README.md

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -721,7 +721,7 @@ well as the [existing list] of feature gates.
721721
-->
722722

723723
- [x] Other
724-
- Describe the mechanism:
724+
- Describe the mechanism: By specifying `--cross-namespace-snapshot=true` command line flag of CSI external-provisioner and creating `VolumePopulator` CR to allow populating from `VolumeSnapshotLink` CR.
725725
- Will enabling / disabling the feature require downtime of the control
726726
plane? No, it won't require downtime of the entire control plane. However, it will require a downtime of each provisioner whose enablement is being changed.
727727
- Will enabling / disabling the feature require downtime or reprovisioning
@@ -734,7 +734,8 @@ Any change of default behavior may be surprising to users or break existing
734734
automations, so be extremely careful here.
735735
-->
736736

737-
Yes, `VolumeSnapshotLink` CRD can be used as a `DataSourceRef` for PVC.
737+
No. Existing behavior of provisioning volumes from PVC and `VolumeSnapshot` remains unchanged.
738+
By enabling the feature, `VolumeSnapshotLink` CR can be used as a `DataSourceRef` for PVC, in addition to the existing data sources.
738739

739740
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
740741

@@ -749,11 +750,17 @@ feature.
749750
NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
750751
-->
751752

752-
Yes, by specifying `--cross-namespace-snapshot=false` command line flag of CSI external-provisioner and deleting `VolumePopulator` CRD to deny popluating from `VolumeSnapshotLink` CRD.
753+
Yes, by specifying `--cross-namespace-snapshot=false` command line flag of CSI external-provisioner and deleting `VolumePopulator` CR to deny populating from `VolumeSnapshotLink` CR.
754+
755+
- After `--cross-namespace-snapshot=false` command line flag is specified: CSI external-provisioner for the csi driver doesn't provision volume from `VolumeSnapshotLink` CR.
756+
- After `VolumePopulator` CR for `VolumeSnapshotLink` CR is deleted: volume-data-source-validator adds an event to PVC that `VolumeSnapshotLink`isn't a valid data source.
753757

754758
###### What happens if we reenable the feature if it was previously rolled back?
755759

756-
`VolumeSnapshotLink` CRD can be used as a `DataSourceRef` for PVC, again.
760+
`VolumeSnapshotLink` CR can be used as a `DataSourceRef` for PVC, again.
761+
762+
PVCs with `VolumeSnapshotLink` data source may be created while the feature is disabled (and volumes for the PVCs aren't provisioned).
763+
After the feature is reenabled, volumes for the PVCs will be provisioned retrospectively.
757764

758765
###### Are there any tests for feature enablement/disablement?
759766

@@ -770,7 +777,7 @@ You can take a look at one potential example of such test in:
770777
https://github.com/kubernetes/kubernetes/pull/97058/files#diff-7826f7adbc1996a05ab52e3f5f02429e94b68ce6bce0dc534d1be636154fded3R246-R282
771778
-->
772779

773-
Yes, unit tests cover scenarios where the feature is disabled or enabled.
780+
No. Unit tests that cover scenarios where the feature is disabled or enabled will be added.
774781

775782
### Rollout, Upgrade and Rollback Planning
776783

keps/sig-storage/3294-provision-volumes-from-cross-namespace-snapshots/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ milestone:
4949
# components:
5050
# - kube-apiserver
5151
# - kube-controller-manager
52-
#disable-supported: true
52+
disable-supported: true
5353

5454
# The following PRR answers are required at beta release
5555
#metrics:

0 commit comments

Comments
 (0)