You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: keps/sig-storage/3294-provision-volumes-from-cross-namespace-snapshots/README.md
+12-5Lines changed: 12 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -721,7 +721,7 @@ well as the [existing list] of feature gates.
721
721
-->
722
722
723
723
- [x] Other
724
-
- Describe the mechanism:
724
+
- Describe the mechanism:By specifying `--cross-namespace-snapshot=true` command line flag of CSI external-provisioner and creating `VolumePopulator` CR to allow populating from `VolumeSnapshotLink` CR.
725
725
- Will enabling / disabling the feature require downtime of the control
726
726
plane? No, it won't require downtime of the entire control plane. However, it will require a downtime of each provisioner whose enablement is being changed.
727
727
- Will enabling / disabling the feature require downtime or reprovisioning
@@ -734,7 +734,8 @@ Any change of default behavior may be surprising to users or break existing
734
734
automations, so be extremely careful here.
735
735
-->
736
736
737
-
Yes, `VolumeSnapshotLink` CRD can be used as a `DataSourceRef` for PVC.
737
+
No. Existing behavior of provisioning volumes from PVC and `VolumeSnapshot` remains unchanged.
738
+
By enabling the feature, `VolumeSnapshotLink` CR can be used as a `DataSourceRef` for PVC, in addition to the existing data sources.
738
739
739
740
###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?
740
741
@@ -749,11 +750,17 @@ feature.
749
750
NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
750
751
-->
751
752
752
-
Yes, by specifying `--cross-namespace-snapshot=false` command line flag of CSI external-provisioner and deleting `VolumePopulator` CRD to deny popluating from `VolumeSnapshotLink` CRD.
753
+
Yes, by specifying `--cross-namespace-snapshot=false` command line flag of CSI external-provisioner and deleting `VolumePopulator` CR to deny populating from `VolumeSnapshotLink` CR.
754
+
755
+
- After `--cross-namespace-snapshot=false` command line flag is specified: CSI external-provisioner for the csi driver doesn't provision volume from `VolumeSnapshotLink` CR.
756
+
- After `VolumePopulator` CR for `VolumeSnapshotLink` CR is deleted: volume-data-source-validator adds an event to PVC that `VolumeSnapshotLink`isn't a valid data source.
753
757
754
758
###### What happens if we reenable the feature if it was previously rolled back?
755
759
756
-
`VolumeSnapshotLink`CRD can be used as a `DataSourceRef` for PVC, again.
760
+
`VolumeSnapshotLink`CR can be used as a `DataSourceRef` for PVC, again.
761
+
762
+
PVCs with `VolumeSnapshotLink` data source may be created while the feature is disabled (and volumes for the PVCs aren't provisioned).
763
+
After the feature is reenabled, volumes for the PVCs will be provisioned retrospectively.
757
764
758
765
###### Are there any tests for feature enablement/disablement?
759
766
@@ -770,7 +777,7 @@ You can take a look at one potential example of such test in:
0 commit comments