You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: keps/sig-storage/1432-volume-health-monitor/README.md
+6-12Lines changed: 6 additions & 12 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -145,7 +145,7 @@ The volume health monitoring by Kubelet will be controlled by a new feature gate
145
145
146
146
### Kubelet Metrics changes
147
147
148
-
Add two new fields in the [VolumeStats metrics API](https://github.com/kubernetes/kubernetes/blob/v1.22.1/staging/src/k8s.io/kubelet/pkg/apis/stats/v1alpha1/types.go#L263).
148
+
Add a new field in the [VolumeStats metrics API](https://github.com/kubernetes/kubernetes/blob/v1.22.1/staging/src/k8s.io/kubelet/pkg/apis/stats/v1alpha1/types.go#L263).
149
149
150
150
```
151
151
// VolumeStats contains data about Volume filesystem usage.
@@ -164,15 +164,10 @@ type VolumeStats struct {
164
164
// An abnormal volume does not meet these criteria.
165
165
// +optional
166
166
Abnormal *bool `json:"abnormal,omitempty"`
167
-
168
-
// Note: Add the following new field
169
-
// The message describing the condition of the volume.
170
-
// +optional
171
-
Message *string `json:"message,omitempty"`
172
167
}
173
168
```
174
169
175
-
Modify [parsePodVolumeStats](https://github.com/kubernetes/kubernetes/blob/v1.22.1/pkg/kubelet/server/stats/volume_stat_calculator.go#L172) to include the new fields in the returned `stats.VolumeStats`.
170
+
Modify [parsePodVolumeStats](https://github.com/kubernetes/kubernetes/blob/v1.22.1/pkg/kubelet/server/stats/volume_stat_calculator.go#L172) to include the new field in the returned `stats.VolumeStats`.
176
171
177
172
The newly added Volume Health stats will be stored in [persistentStats](https://github.com/kubernetes/kubernetes/blob/v1.22.1/pkg/kubelet/server/stats/volume_stat_calculator.go#L168).
178
173
@@ -182,12 +177,11 @@ Add new metrics [here](https://github.com/kubernetes/kubernetes/blob/v1.22.1/pkg
Update [CollectWithStability](https://github.com/kubernetes/kubernetes/blob/v1.22.1/pkg/kubelet/metrics/collectors/volume_stats.go#L117) to add a [NewLazyConstMetric](https://github.com/kubernetes/component-base/blob/v0.22.1/metrics/value.go#L33) with an [GaugeValue](https://github.com/kubernetes/component-base/blob/v0.22.1/metrics/value.go#L32).
189
183
190
-
Since Prometheus does not store string metrics, `VolumeStatsHealthAbnormal` will be stored as either 1 or 0 and `VolumeStatsHealthMessage` will be added as a label in the same metric named `VolumeStatsHealthAbnormal`.
184
+
Since Prometheus does not store string metrics, `VolumeStatsHealthAbnormal` will be stored as either 1 or 0.
191
185
192
186
### CSI changes
193
187
@@ -911,13 +905,13 @@ previous answers based on experience in the field._
911
905
call is needed.
912
906
- API calls that may be triggered by changes of some Kubernetes resources
913
907
(e.g. update of object X triggers new updates of object Y)
914
-
We are adding new `Abnormal`and `Message` fields to the existing Kubelet metrics API. It will be retrieved by the periodic metrics collection call. We are not changing the existing frequency of that call.
908
+
We are adding a new `Abnormal`field to the existing Kubelet metrics API. It will be retrieved by the periodic metrics collection call. We are not changing the existing frequency of that call.
915
909
- periodic API calls to reconcile state (e.g. periodic fetching state,
916
910
heartbeats, leader election, etc.)
917
911
918
912
***Will enabling / using this feature result in introducing new API types?**
919
913
Describe them, providing:
920
-
- API type: Adding 'Abnormal`and `Message` fields to Kubelet VolumeStats metrics API
914
+
- API type: Adding 'Abnormal` field to Kubelet VolumeStats metrics API
921
915
- Supported number of objects per cluster: No
922
916
- Supported number of objects per namespace (for namespace-scoped objects): No
923
917
@@ -928,7 +922,7 @@ provider?**
928
922
***Will enabling / using this feature result in increasing size or count of
929
923
the existing API objects?**
930
924
Describe them, providing:
931
-
- API type(s): Yes. We are adding new 'Abnormal`and `Message` fields to Kubelet VolumeStats metrics API.
925
+
- API type(s): Yes. We are adding new 'Abnormal` field to Kubelet VolumeStats metrics API.
932
926
- Estimated increase in size: (e.g., new annotation of size 32B):
933
927
New string of max length of 128 bytes; new int of 4 bytes.
934
928
- Estimated amount of new objects: (e.g., new Object X for every existing Pod)
0 commit comments