Skip to content

Commit e1bcf82

Browse files
committed
Changed VolumeGroupHandle to PersistentVolumeNames.
1 parent 9d51ef1 commit e1bcf82

File tree

1 file changed

+4
-1
lines changed
  • keps/sig-storage/3476-volume-group-snapshot

1 file changed

+4
-1
lines changed

keps/sig-storage/3476-volume-group-snapshot/README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,9 @@ The controller will retrieve all volumeSnapshotHandles in the Volume Group Snaps
186186
A VolumeGroupSnapshot can be deleted if the CSI driver supports the CREATE_DELETE_GET_VOLUME_GROUP_SNAPSHOT capability.
187187
* When a VolumeGroupSnapshot is deleted, the VolumeGroupSnapshot controller will call the DeleteVolumeGroupSnapshot CSI function which will delete individual snapshots as well.
188188
* Since CSI driver handles individual snapshot creation in CreateVolumeGroupSnapshot, it should handle individual snapshot deletion in DeleteVolumeGroupSnapshot as well. DeleteSnapshot CSI function will not be called.
189+
* When DeleteVolumeGroupSnapshot CSI function returns success, it is assumed that all individual snapshots on the storage system have been deleted. VolumeGroupSnapshot controller should remove all the finalizers and delete the VolumeSnapshot and VolumeSnapshotContent API objects.
189190
* DeleteSnapshot on a single snapshot that belongs to a group snapshot is not allowed.
191+
* The Snapshot Controller and csi-snapshotter sidecar will be modified to skip the handling of VolumeSnapshot and VolumeSnapshotContent deletion if they are part of a group.
190192

191193
### Restore
192194

@@ -426,8 +428,9 @@ type VolumeGroupSnapshotContentSpec struct {
426428
// OneOf
427429
type VolumeGroupSnapshotContentSource struct {
428430
// Dynamical provisioning of VolumeGroupSnapshot
431+
// A list of PersistentVolume names to be snapshotted together
429432
// +optional
430-
VolumeGroupHandle *string
433+
PersistentVolumeNames []string
431434
432435
// Pre-provisioned VolumeGroupSnapshot
433436
// +optional

0 commit comments

Comments
 (0)