KEP 2371: move some beta criteria to alpha criteria

and move the KEP stage to alpha, as more work is needed before the KEP can be considered alpha

Signed-off-by: Peter Hunt <[email protected]>

Author: haircommander

keps/sig-node/2371-cri-pod-container-stats/README.md

@@ -235,9 +235,10 @@ This will be described in more detail in the [design details section](#design-de
 ### /metrics/cadvisor
 
 1. Expose the metric fields provided in `/metrics/cadvisor` in an analogous Prometheus endpoint directly from the CRI implementation.
-5. cAdvisor should be updated to support no longer collecting stats that are duplicated with CRI implementation, and omit them from the report sent to `/metrics/cadvisor`.
+2. cAdvisor should be updated to support no longer collecting stats that are duplicated with CRI implementation, and omit them from the report sent to `/metrics/cadvisor`.
 3. The precise endpoint can change, but all the fields should be duplicated (so custom rules can be maintained).
 4. Kubelet does not collect nor expose pod and container level metrics that were formally collected for and exposed by `/metrics/cadvisor`.
+5. Kubelet should broadcast the endpoint from the CRI, similarly to how it does for `/metrics/cadvisor`.
 
 ### User Stories [optional]
 
@@ -268,7 +269,6 @@ Thus, this KEP largely the plan described [here](#plan), with some changes:
 #### Open Questions
 1. For the newly introduced CRI API fields, should there be Windows and Linux specific fields?
 
-
 ### Risks and Mitigations
 
 - To properly move to CRI stats, it is likely there are some metrics that we'll want to not support (Accelerator/UserDefined). We should be careful to not break entities that rely on these metrics.
@@ -527,7 +527,6 @@ Below is the proposed strategy for doing so:
 
 As a requirement for the Beta stage, cAdvisor must support optionally collecting and broadcasting these metrics, similarly to the changes needed for summary API.
 
-
 ### Test Plan
 
 - Internally in the Kubelet, there should be integration tests verifying that information gotten from the two sources is not too different.
@@ -540,6 +539,9 @@ As a requirement for the Beta stage, cAdvisor must support optionally collecting
 - CRI should be extended to provide required stats for `/stats/summary`
 - Kubelet should be extended to provide the required stats from CRI implementation for `/stats/summary`.
 - This new behavior will be gated by a feature gate to prevent regressions for users that rely on the old behavior.
+- cAdvisor should be able to optionally not report the metrics needed for both summary API and `/metrics/cadvisor`. This behavior will be toggled by the Kubelet feature gate.
+- Kubelet will query the CRI implementation for endpoints to broadcast from its own server.
+	- This will allow the CRI to broadcast `/metrics/cadvisor` through the Kubelet's HTTP server.
 
 #### Alpha -> Beta Graduation
 
@@ -548,7 +550,6 @@ As a requirement for the Beta stage, cAdvisor must support optionally collecting
 - Validate performance impact of this feature is within allowable margin (or non-existent, ideally).
 	- The CRI stats implementation should perform better than they did with CRI+cAdvisor.
 - cAdvisor stats provider may be marked as deprecated (depending on stability of new CRI based implementations).
-- cAdvisor should be able to optionally not report the metrics needed for both summary API and `/metrics/cadvisor`. This behavior will be toggled by the Kubelet feature gate.
 
 #### Beta -> GA Graduation
 
@@ -788,11 +789,13 @@ _This section must be completed when targeting beta graduation to a release._
 
 ## Implementation History
 
-2021-1-27: KEP opened
-2021-5-12: KEP merged, targeted at Alpha in 1.22
-2021-7-8: KEP deemed not ready for Alpha in 1.22
+2021-01-27: KEP opened
+2021-05-12: KEP merged, targeted at Alpha in 1.22
+2021-07-08: KEP deemed not ready for Alpha in 1.22
 2021-12-07: KEP successfully implemented at Alpha in 1.23
-2022-1-25: KEP targeted at Beta in 1.24
+2022-01-25: KEP targeted at Beta in 1.24
+2022-04-20: KEP deemed not ready for Beta in 1.24
+2022-06-13: Move some Beta criteria to Alpha criteria in 1.25
 
 ## Drawbacks
 

keps/sig-node/2371-cri-pod-container-stats/kep.yaml

@@ -16,13 +16,12 @@ approvers:
 prr-approvers:
   - "@ehashman"
 creation-date: 2021-01-27
-last-updated: 2022-01-25
+last-updated: 2022-06-13
 status: implementable
-stage: beta
-latest-milestone: "v1.24"
+stage: alpha
+latest-milestone: "v1.23"
 milestone:
   alpha: "v1.23"
-  beta: "v1.24"
 see-also:
   - N/A
 replaces: