Skip to content

Commit ed3df05

Browse files
Update test plan
1 parent e1a6ad5 commit ed3df05

File tree

1 file changed

+30
-1
lines changed
  • keps/sig-windows/2802-identify-windows-pods-apiserver-admission

1 file changed

+30
-1
lines changed

keps/sig-windows/2802-identify-windows-pods-apiserver-admission/README.md

Lines changed: 30 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
- [Changes to Kubelet](#changes-to-kubelet)
2121
- [Potential future changes to Scheduler](#potential-future-changes-to-scheduler)
2222
- [Test Plan](#test-plan)
23+
- [Prerequisite testing updates](#prerequisite-testing-updates)
24+
- [Unit tests](#unit-tests)
25+
- [Integration tests](#integration-tests)
26+
- [e2e tests](#e2e-tests)
2327
- [Graduation Criteria](#graduation-criteria)
2428
- [Alpha](#alpha)
2529
- [Alpha -> Beta Graduation](#alpha---beta-graduation)
@@ -186,7 +190,32 @@ express scheduling constraints. During the alpha, we assume there are no schedul
186190
- Unit tests covering API server defaulting to various fields within pod with and without this feature
187191
- Unit tests covering admission plugins which validate/mutate pod spec based on this feature
188192
- Unit and E2E tests for Kubelet changes.
189-
- Updates to the `sig-windows` tagged tests to utilize to direct windows scheduling for all pods .
193+
- Updates to the `sig-windows` tagged tests to utilize to direct windows scheduling for all pods.
194+
195+
#### Prerequisite testing updates
196+
[x] I/we understand the owners of the involved components may require updates to existing tests to make this code solid enough prior to committing the changes necessary to implement this enhancement.
197+
198+
##### Unit tests
199+
200+
`k8s.io/kubernetes/pkg/apis/core/validation`: `06/03/2022` `82.1% of statements`
201+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:2979`: `06/03/2022`: `76.2% of statements`
202+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:3488`: `06/03/2022`: `92.0% of statements`
203+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:3573`: `06/03/2022`: `100.0% of statements`
204+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:3590`: `06/03/2022`: `65.3% of statements`
205+
`k8s.io/kubernetes/pkg/apis/core/validation/validation.go:6360`: `06/03/2022`: `100.0% of statements`
206+
207+
##### Integration tests
208+
209+
The pod security standard integration tests will be updated to include OS specific validations.
210+
211+
212+
##### e2e tests
213+
214+
There are e2e tests which
215+
- validate that the kubelet rejects the pod which have os field not matching the underlying OS
216+
- validate that the kubelet reconciles and corrects if the node's OS label is changed
217+
218+
190219
### Graduation Criteria
191220

192221
#### Alpha

0 commit comments

Comments
 (0)