Skip to content

Commit efe27c7

Browse files
committed
WIP: another pass at SLOs
Signed-off-by: Andrew Keesler <[email protected]>
1 parent 35617dc commit efe27c7

File tree

1 file changed

+7
-4
lines changed
  • keps/sig-auth/541-external-credential-providers

1 file changed

+7
-4
lines changed

keps/sig-auth/541-external-credential-providers/README.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -834,10 +834,13 @@ _This section must be completed when targeting beta graduation to a release._
834834
- This feature set operates on the client-side.
835835

836836
* **What are the reasonable SLOs (Service Level Objectives) for the above SLIs?**
837-
- `rest_client_exec_plugin_ttl_seconds`: the expected lifetime of client-side certificates, in seconds
838-
- `rest_client_exec_plugin_certificate_rotation_age`: the expected lifetime of client-side certificates, in seconds
839-
- `rest_client_exec_plugin_calls`: 1 per the lifetime of the credential returned by the exec plugin
840-
- `rest_client_exec_plugin_failed_calls`: 0, or a very low number compared to `rest_client_exec_plugin_calls`
837+
- We target certificate rotations to happen within 1% of a certificate's
838+
lifetime. This is measured by
839+
`rest_client_exec_plugin_certificate_rotation_age` and
840+
`rest_client_exec_plugin_ttl_seconds`.
841+
- We target 0.01% unsuccessful calls to the exec plugin in a moving 24h
842+
window. This is measured by
843+
`rest_client_exec_plugin_calls` and `rest_client_exec_plugin_failed_calls`.
841844

842845
* **Are there any missing metrics that would be useful to have to improve
843846
observability if this feature?**

0 commit comments

Comments
 (0)