Skip to content

Commit f1bffd7

Browse files
authored
Merge pull request kubernetes#3897 from pacoxu/update-parallel-image-behavior
KEP-3673 update: parallel pull defaulting and validation logics according to the merged PR
2 parents 0a564be + df634fc commit f1bffd7

File tree

1 file changed

+12
-3
lines changed
  • keps/sig-node/3673-kubelet-parallel-image-pull-limit

1 file changed

+12
-3
lines changed

keps/sig-node/3673-kubelet-parallel-image-pull-limit/README.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -233,9 +233,18 @@ implementation. What is the desired outcome and how do we measure success?.
233233
The "Design Details" section below is for the real
234234
nitty-gritty.
235235
-->
236-
* A new integer field `maxParallelImagePulls` will be added to Kubelet Configuration. `maxParallelImagePulls` is the maximum number of inflight image pulls.
237-
* The default value of `maxParallelImagePulls` will be set to 0, which applies no limit on parallel pulls, the same as current behavior.
238-
* When `serialize-image-pulls` is true, `maxParallelImagePulls` will be ignored. A warning message will be logged by kubelet if `serialize-image-pulls` is true and `maxParallelImagePulls` is larger than 1.
236+
Before this proposal, `serialize-image-pulls` is by default true.
237+
238+
This proposal includes some defaulting and validation logics.
239+
240+
- A new integer field `maxParallelImagePulls` will be added to Kubelet Configuration. `maxParallelImagePulls` is the maximum number of inflight image pulls.
241+
- If both `serialize-image-pulls` and `maxParallelImagePulls` are not set, the default value of `serialize-image-pulls` will be true by default, which applies no limit on parallel pulls, the same as current behavior.(It indicates that maxParallelImagePulls is 1.)
242+
- If `serialize-image-pulls` is not set and `maxParallelImagePulls` is set, the default value of `serialize-image-pulls` will depend on `maxParallelImagePulls`.
243+
- If `maxParallelImagePulls` is 1, `serialize-image-pulls` will be set to true by default.
244+
- If `maxParallelImagePulls` is larger than 1, `serialize-image-pulls` will be set to false by default.
245+
- If both `serialize-image-pulls` and `maxParallelImagePulls` are set, there would be some validations.
246+
- If `serialize-image-pulls` is set to true, `maxParallelImagePulls` should be nil or 1. If `maxParallelImagePulls` is larger than 1, the configuration validation will fail.
247+
- If `serialize-image-pulls` is set to false, `maxParallelImagePulls` should be larger than 0. If `maxParallelImagePulls` is less than 1, the configuration validation will fail.
239248

240249
### User Stories (Optional)
241250

0 commit comments

Comments
 (0)