You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: keps/sig-instrumentation/1602-structured-logging/README.md
+12-15Lines changed: 12 additions & 15 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -373,28 +373,25 @@ Klog interface was selected as it is already supported by klog.v2 with `SetLogge
373
373
374
374
Introduce structured logging and JSON format:
375
375
* Most important logs are migrated to structured methods.
376
-
* Flag for selecting logging format is implemented
377
-
* JSON format is implemented
376
+
* Flag for selecting logging format is implemented.
377
+
* JSON format is implemented.
378
378
379
379
#### Beta
380
380
381
-
Adding guarding against regression and update user guideline:
382
-
* Static analysis protects important log lines from reverting to string formating
383
-
*[Kubernetes Logging convention](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md) document is updated
384
-
385
-
Components in scope:
386
-
* Kubelet
387
-
388
-
All other component migrations will be best effort.
381
+
Bring feature quality up to and prevent regression during ongoing migration:
382
+
* Directories can be marked as migrated, preventing regression via verify script in `hack`.
383
+
*[Kubernetes Logging documentation](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md) is updated for structured logging.
384
+
* Json format should support same set of feature flags as text format, minus those we will decide to deprecte.
385
+
* Structured logging interface design is verify by migrating one whole component (Kubelet) to structured logging. All other component migrations will be best effort.
389
386
390
387
#### GA
391
388
392
389
Logging formats become an API:
393
-
* Feedback about logging methods and log formats is collected and addressed
394
-
* Format string methods are deprecated
395
-
* Static analysis protects against creating new string format calls
396
-
* Logging output formats fall under [Kubernetes deprecation policy](https://kubernetes.io/docs/reference/using-api/deprecation-policy/)
397
-
* All remaining components must be migrated
390
+
* Feedback about logging methods and log formats is collected and addressed.
391
+
* Format string methods are deprecated.
392
+
* Static analysis protects against creating new string format calls.
393
+
* Logging output formats fall under [Kubernetes deprecation policy](https://kubernetes.io/docs/reference/using-api/deprecation-policy/).
0 commit comments