Skip to content

Commit f8b9150

Browse files
committed
pr feedback
1 parent 5867720 commit f8b9150

File tree

1 file changed

+6
-2
lines changed
  • keps/sig-windows/5100-windows-dsr-and-overlay-support

1 file changed

+6
-2
lines changed

keps/sig-windows/5100-windows-dsr-and-overlay-support/README.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ demonstrate the interest in a KEP within the wider Kubernetes community.
196196

197197
DSR support was added to Windows Server 2019 as part of the May 2020 update.
198198
DSR provides performance optimizations by allowing the return traffic routed through load balancers to bypass the load balancer and respond directly to the client; reducing load on the load balancer and also reducing overall latency.
199+
More information on DSR on Windows can be found [here](https://techcommunity.microsoft.com/blog/networkingblog/direct-server-return-dsr-in-a-nutshell/693710).
199200

200201
Overlay networking mode is a common networking mode used in Kubernetes clusters and is required by some for some important scenarios like network policy support with Calico CNI.
201202
Adding support for overlay networking mode in Windows kube-proxy will allow users to use more CNI soluitons with Windows nodes.
@@ -230,6 +231,9 @@ nitty-gritty.
230231
DSR and Overlay networking mode support is already implemented in Windows kube-proxy and has been extensively tested in the Windows CI pipeline.
231232
This proposal is to promote the existing implementations to GA.
232233

234+
Additionally, DSR support on Windows is supported on both EKS and AKS.
235+
Both DSR and overlay networking support have been used in the Windows CI pipelines running release-informing
236+
233237
### User Stories (Optional)
234238

235239
<!--
@@ -279,7 +283,7 @@ Enabling DSR and overlay networking mode support in Windows kube-proxy both have
279283
For DSR, the Windows Host Network Service handles all of the logic for managing network traffic; kube-proxy only needs to specify if DSR should be used when creating/sycing load balancer rules.
280284
Additionally, DSR must be enabled with a kube-proxy command switch switch (--enable-dsr=true) disabling DSR is can be performed by redeploying kube-proxy on Windows nodes.
281285

282-
Overlay networking support in Windows has been used in the Windows CI pipelines running release-informing jobs for many releases and is considered stable.
286+
Overlay networking support in Windows has been used in the Windows CI pipelines running release-informing [capz-windows-master](https://testgrid.k8s.io/sig-windows-signal#capz-windows-master) jobs since K8s v1.20.
283287

284288
## Design Details
285289

@@ -301,7 +305,7 @@ Checks for ternminating and service enpoints handle DSR traffic differently than
301305
- Local endpoints will be skipped when determining if all endpoints for a service are terminated if DSR is enabled and service type is load balancer.
302306
- Non-local endpoints will be skipped when considering if all endpoints for a service are non-serving if DSR is enabled and service type is load balancer.
303307

304-
Flags passed to HNS calls used for the following operators will be updated to include a flag indicating if DSR is enabled for all get, create, and update loadbalancer HNS calls.
308+
Flags passed to HNS (Host Networking Service) calls used for the following operators will be updated to include a flag indicating if DSR is enabled for all get, create, and update loadbalancer HNS calls.
305309

306310

307311
### Overlay support

0 commit comments

Comments
 (0)