Skip to content

Commit fa25a10

Browse files
authored
Merge pull request kubernetes#3595 from logicalhan/amend-slis
amend feature gate name to be accurate
2 parents 80aa21f + ee9db22 commit fa25a10

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

keps/sig-instrumentation/3466-kubernetes-component-health-slis/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,13 +331,13 @@ We do not plan to modify these metrics, so it should be safe for version skew.
331331

332332
### Feature Enablement and Rollback
333333

334-
We will target this feature behind a flag `ComponentHealthSLIsFeatureGate`
334+
We will target this feature behind a flag `ComponentSLIs`
335335

336336
###### How can this feature be enabled / disabled in a live cluster?
337337

338338

339339
- [ ] Feature gate (also fill in values in `kep.yaml`)
340-
- Feature gate name: `ComponentSLIsFeatureGate`
340+
- Feature gate name: `ComponentSLIs`
341341
- Components depending on the feature gate:
342342
+ apiserver
343343
+ kubelet

keps/sig-instrumentation/3466-kubernetes-component-health-slis/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ milestone:
2929
stable: "v1.29"
3030

3131
feature-gates:
32-
- name: ComponentSLIsFeatureGate
32+
- name: ComponentSLIs
3333
components:
3434
- kube-apiserver
3535
- kube-controller-manager

0 commit comments

Comments
 (0)