@@ -553,27 +553,9 @@ This section must be completed when targeting alpha to a release.
553
553
554
554
###### How can this feature be enabled / disabled in a live cluster?
555
555
556
- <!--
557
- Pick one of these and delete the rest.
558
-
559
- Documentation is available on [feature gate lifecycle] and expectations, as
560
- well as the [existing list] of feature gates.
561
-
562
- [feature gate lifecycle]: https://git.k8s.io/community/contributors/devel/sig-architecture/feature-gates.md
563
- [existing list]: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/
564
- -->
565
-
566
556
- [x] Feature gate (also fill in values in ` kep.yaml ` )
567
557
- Feature gate name: SplitStdoutAndStderr
568
558
- Components depending on the feature gate: kubelet, kube-apiserver
569
- - [x] Other
570
- - Describe the mechanism: query parameter
571
- - Will enabling / disabling the feature require downtime of the control
572
- plane?
573
- - No.
574
- - Will enabling / disabling the feature require downtime or reprovisioning
575
- of a node? (Do not assume ` Dynamic Kubelet Config ` feature is enabled).
576
- - No.
577
559
578
560
###### Does enabling the feature change any default behavior?
579
561
@@ -586,20 +568,13 @@ Yes.
586
568
587
569
###### What happens if we reenable the feature if it was previously rolled back?
588
570
589
- ###### Are there any tests for feature enablement/disablement?
571
+ No harm, It becomes enabled again after the ` kubelet ` and ` kube-apiserver ` restart.
572
+ The log files do not change when the feature is on compared to when it is off.
590
573
591
- <!--
592
- The e2e framework does not currently support enabling or disabling feature
593
- gates. However, unit tests in each component dealing with managing data, created
594
- with and without the feature, are necessary. At the very least, think about
595
- conversion tests if API types are being modified.
574
+ ###### Are there any tests for feature enablement/disablement?
596
575
597
- Additionally, for features that are introducing a new API field, unit tests that
598
- are exercising the `switch` of feature gate itself (what happens if I disable a
599
- feature gate after having objects written with the new field) are also critical.
600
- You can take a look at one potential example of such test in:
601
- https://github.com/kubernetes/kubernetes/pull/97058/files#diff-7826f7adbc1996a05ab52e3f5f02429e94b68ce6bce0dc534d1be636154fded3R246-R282
602
- -->
576
+ Yes, unit tests for the feature when enabled and disabled will be
577
+ implemented in both kubelet and api server.
603
578
604
579
### Rollout, Upgrade and Rollback Planning
605
580
0 commit comments