Skip to content

Commit fb1e5bd

Browse files
committed
Take care of PRR review comments.
1 parent 2249474 commit fb1e5bd

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

keps/sig-node/4540-strict-cpu-reservation/README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ When `strict-cpu-reservation` is enabled:
129129

130130
### Risks and Mitigations
131131

132-
The feature is isolated to a specific policy option `strict-cpu-reservation` under `cpuManagerPolicyOptions` and is protected by feature gate `CPUManagerPolicyBetaOptions` before the feature graduates to `Stable` i.e. enabled by default.
132+
The feature is isolated to a specific policy option `strict-cpu-reservation` under `cpuManagerPolicyOptions` and is protected by feature gate `CPUManagerPolicyBetaOptions` before the feature graduates to `Stable` i.e. always enabled.
133133

134134
Concern for feature impact on best-effort workloads, the workloads that do not have resource requests, is brought up.
135135

@@ -405,7 +405,9 @@ Longer term, we may want to require automated upgrade/rollback tests, but we
405405
are missing a bunch of machinery and tooling and can't do that now.
406406
-->
407407

408-
We use the feature in our internal environment and it works.
408+
End users have this feature enabled in v1.32 under `CPUManagerPolicyAlphaOptions` (default to false) will continue to have the feature enabled in v1.33 under `CPUManagerPolicyBetaOptions` (default to true) automatically i.e. no extra action is needed.
409+
410+
To enable or disable this feature in v1.33, follow the feature activation and de-activation procedures described above.
409411

410412
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
411413

@@ -514,6 +516,7 @@ You can safely disable the feature.
514516

515517
- 2024-03-08: Initial KEP created
516518
- 2024-10-07: KEP gets LGTM and Approval
519+
- 2025-02-03: KEP updated with Beta criteria
517520

518521

519522
## Drawbacks

keps/sig-node/4540-strict-cpu-reservation/kep.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,8 @@ milestone:
3131
# The following PRR answers are required at alpha release
3232
# List the feature gate name and the components for which it must be enabled
3333
feature-gates:
34-
- name: "CPUManagerPolicyAlphaOptions"
35-
components:
36-
- kubelet
3734
- name: "CPUManagerPolicyBetaOptions"
38-
components:
35+
components:
3936
- kubelet
4037

4138
disable-supported: true

0 commit comments

Comments
 (0)