Skip to content

Commit fbbe62a

Browse files
committed
Address comments
Signed-off-by: Rita Zhang <[email protected]>
1 parent a7dde44 commit fbbe62a

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

keps/sig-auth/3299-kms-v2-improvements/README.md

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
- [Troubleshooting](#troubleshooting)
2525
- [Implementation History](#implementation-history)
2626
- [Alternatives](#alternatives)
27+
- [Infrastructure Needed](#infrastructure-needed)
2728
<!-- /toc -->
2829

2930
## Release Signoff Checklist
@@ -184,8 +185,6 @@ The `DecryptRequest` passes the same `currentKeyID` and `metadata` returned by t
184185

185186
```proto
186187
message DecryptRequest {
187-
// Version of the KMS plugin API.
188-
string version = 1;
189188
// The data to be decrypted.
190189
bytes cipher = 2;
191190
// UID is a unique identifier for the request.
@@ -207,8 +206,6 @@ message DecryptResponse {
207206
}
208207
209208
message EncryptRequest {
210-
// Version of the KMS plugin API.
211-
string version = 1;
212209
// The data to be encrypted.
213210
bytes plain = 2;
214211
// UID is a unique identifier for the request.
@@ -516,3 +513,12 @@ We considered using the `AuditID` from the kube-apiserver request that generated
516513
1. `AuditID` can be configured by the user with the `Audit-ID` header in the API server request. Multiple requests can be sent to the kube-apiserver with the same `Audit-ID`.
517514
2. Not all API server requests will generate an envelope operation. The API server caches DEKs and for the DEK that's available in the cache, the kube-apiserver will not generate an envelope operation.
518515
3. Since not all calls to the KMS correspond to an audit log, using audit ID is not complete for correlating calls from kube-apiserver->kms-plugin->KMS.
516+
517+
## Infrastructure Needed
518+
519+
<!--
520+
Use this section if you need things from the project/SIG. Examples include a
521+
new subproject, repos requested, or GitHub details. Listing these here allows a
522+
SIG to get the process for these resources started right away.
523+
-->
524+
We need a new git repo for the KMS plugin reference implementation. It will need to be synced from the k/k staging dir.

keps/sig-auth/3299-kms-v2-improvements/kep.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ reviewers:
1212
- "@enj"
1313
approvers:
1414
- "@smarterclayton"
15+
replaces:
16+
- "/keps/sig-auth/3130-kms-observability"
1517
stage: alpha
1618
latest-milestone: "v1.25"
1719
# The milestone at which this feature was, or is targeted to be, at each stage.

0 commit comments

Comments
 (0)