Skip to content

Commit 6c9d585

Browse files
authored
[PWGLF] fix o2linter complaints for magic numbers (AliceO2Group#10729)
1 parent f4931f9 commit 6c9d585

File tree

1 file changed

+28
-12
lines changed

1 file changed

+28
-12
lines changed

PWGLF/Tasks/Nuspex/antinucleiInJets.cxx

Lines changed: 28 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -364,27 +364,39 @@ struct AntinucleiInJets {
364364
template <typename JetTrack>
365365
bool passedTrackSelectionForJetReconstruction(const JetTrack& track)
366366
{
367+
368+
const int minTpcCr = 70;
369+
const double minCrFindable = 0.8;
370+
const double maxChi2Tpc = 4.0;
371+
const double maxChi2Its = 36.0;
372+
const double maxPseudorapidity = 0.8;
373+
const double minPtTrack = 0.1;
374+
const double dcaxyMaxTrackPar0 = 0.0105;
375+
const double dcaxyMaxTrackPar1 = 0.035;
376+
const double dcaxyMaxTrackPar2 = 1.1;
377+
const double dcazMaxTrack = 2.0;
378+
367379
if (!track.hasITS())
368380
return false;
369381
if ((!hasITSHit(track, 1)) && (!hasITSHit(track, 2)) && (!hasITSHit(track, 3)))
370382
return false;
371383
if (!track.hasTPC())
372384
return false;
373-
if (track.tpcNClsCrossedRows() < 70)
385+
if (track.tpcNClsCrossedRows() < minTpcCr)
374386
return false;
375-
if ((static_cast<double>(track.tpcNClsCrossedRows()) / static_cast<double>(track.tpcNClsFindable())) < 0.8)
387+
if ((static_cast<double>(track.tpcNClsCrossedRows()) / static_cast<double>(track.tpcNClsFindable())) < minCrFindable)
376388
return false;
377-
if (track.tpcChi2NCl() > 4)
389+
if (track.tpcChi2NCl() > maxChi2Tpc)
378390
return false;
379-
if (track.itsChi2NCl() > 36)
391+
if (track.itsChi2NCl() > maxChi2Its)
380392
return false;
381-
if (track.eta() < -0.8 || track.eta() > 0.8)
393+
if (track.eta() < -maxPseudorapidity || track.eta() > maxPseudorapidity)
382394
return false;
383-
if (track.pt() < 0.1)
395+
if (track.pt() < minPtTrack)
384396
return false;
385-
if (std::fabs(track.dcaXY()) > (0.0105 + 0.035 / std::pow(track.pt(), 1.1)))
397+
if (std::fabs(track.dcaXY()) > (dcaxyMaxTrackPar0 + dcaxyMaxTrackPar1 / std::pow(track.pt(), dcaxyMaxTrackPar2)))
386398
return false;
387-
if (std::fabs(track.dcaZ()) > 2.0)
399+
if (std::fabs(track.dcaZ()) > dcazMaxTrack)
388400
return false;
389401
return true;
390402
}
@@ -424,10 +436,12 @@ struct AntinucleiInJets {
424436
double nsigmaTPCPr = track.tpcNSigmaPr();
425437
double nsigmaTOFPr = track.tofNSigmaPr();
426438
double pt = track.pt();
439+
double ptThreshold = 0.5;
440+
double nsigmaMaxPr = 2.0;
427441

428-
if (pt < 0.5 && std::fabs(nsigmaTPCPr) < 2.0)
442+
if (pt < ptThreshold && std::fabs(nsigmaTPCPr) < nsigmaMaxPr)
429443
return true;
430-
if (pt >= 0.5 && std::fabs(nsigmaTPCPr) < 2.0 && track.hasTOF() && std::fabs(nsigmaTOFPr) < 2.0)
444+
if (pt >= ptThreshold && std::fabs(nsigmaTPCPr) < nsigmaMaxPr && track.hasTOF() && std::fabs(nsigmaTOFPr) < nsigmaMaxPr)
431445
return true;
432446
return false;
433447
}
@@ -1013,7 +1027,8 @@ struct AntinucleiInJets {
10131027

10141028
if (!particle.isPhysicalPrimary())
10151029
continue;
1016-
if (particle.eta() < -0.8 || particle.eta() > 0.8 || particle.pt() < 0.1)
1030+
double minPtParticle = 0.1;
1031+
if (particle.eta() < minEta || particle.eta() > maxEta || particle.pt() < minPtParticle)
10171032
continue;
10181033

10191034
double energy = std::sqrt(particle.p() * particle.p() + MassPionCharged * MassPionCharged);
@@ -1068,7 +1083,8 @@ struct AntinucleiInJets {
10681083

10691084
if (!particle.isPhysicalPrimary())
10701085
continue;
1071-
if (particle.eta() < -0.8 || particle.eta() > 0.8 || particle.pt() < 0.1)
1086+
double minPtParticle = 0.1;
1087+
if (particle.eta() < minEta || particle.eta() > maxEta || particle.pt() < minPtParticle)
10721088
continue;
10731089

10741090
double deltaEtaUe1 = particle.eta() - ueAxis1.Eta();

0 commit comments

Comments
 (0)