Tests for scope

And some bugfixes

Author: wkillerud

pkgs/sass_language_services/lib/src/features/go_to_definition/scope.dart

@@ -12,7 +12,7 @@ class Scope {
 
   void addChild(Scope scope) {
     children.add(scope);
-    scope.setParent(scope);
+    scope.setParent(this);
   }
 
   void setParent(Scope scope) {
@@ -29,21 +29,17 @@ class Scope {
   }
 
   Scope findInScope({required int offset, int length = 0}) {
-    var limit = offset + length;
-    var index = children.indexWhere((scope) => scope.offset > limit);
-    if (index == 0) {
-      return this;
-    }
+    var scopeAtOffset = children.firstWhere(
+        (scope) =>
+            scope.offset <= offset &&
+            scope.offset + scope.length > offset + length,
+        orElse: () => this);
 
-    var childScope = children.elementAt(index - 1);
-    var childScopeHasOffset = childScope.offset <= offset &&
-        childScope.offset + childScope.length >= offset + length;
-
-    if (childScopeHasOffset) {
-      return childScope.findInScope(offset: offset, length: length);
+    if (scopeAtOffset == this) {
+      return this;
     }
 
-    return this;
+    return scopeAtOffset.findInScope(offset: offset, length: length);
   }
 
   void addSymbol(StylesheetDocumentSymbol symbol) {

pkgs/sass_language_services/test/features/go_to_definition/go_to_definition_tests.dart

@@ -0,0 +1,17 @@
+import 'package:sass_language_services/sass_language_services.dart';
+import 'package:test/test.dart';
+
+import '../../memory_file_system.dart';
+import '../../test_client_capabilities.dart';
+
+final fs = MemoryFileSystem();
+final ls = LanguageServices(fs: fs, clientCapabilities: getCapabilities());
+void main() {
+  group('selectors', () {
+    setUp(() {
+      ls.cache.clear();
+    });
+
+
+  });
+}

pkgs/sass_language_services/test/features/go_to_definition/scope_tests.dart

@@ -0,0 +1,50 @@
+import 'package:sass_language_services/sass_language_services.dart';
+import 'package:sass_language_services/src/features/go_to_definition/scope.dart';
+import 'package:test/test.dart';
+
+import '../../memory_file_system.dart';
+import '../../test_client_capabilities.dart';
+
+final fs = MemoryFileSystem();
+final ls = LanguageServices(fs: fs, clientCapabilities: getCapabilities());
+
+void main() {
+  group('scope', () {
+    setUp(() {
+      ls.cache.clear();
+    });
+
+    test('relationship between scopes', () {
+      var global = Scope(offset: 0, length: double.maxFinite.floor());
+      var first = Scope(offset: 10, length: 5);
+      var second = Scope(offset: 15, length: 5);
+
+      global.addChild(first);
+      global.addChild(second);
+
+      expect(global.children, hasLength(2));
+
+      expect(first.parent, equals(global));
+      expect(second.parent, equals(global));
+    });
+
+    test('findScope', () {
+      var global = Scope(offset: 0, length: double.maxFinite.floor());
+      var first = Scope(offset: 10, length: 5);
+      var second = Scope(offset: 15, length: 5);
+
+      global.addChild(first);
+      global.addChild(second);
+
+      expect(global.findScope(offset: -1), isNull);
+
+      expect(global.findScope(offset: 0), equals(global));
+      expect(global.findScope(offset: 20), equals(global));
+
+      expect(global.findScope(offset: 10), equals(first));
+      expect(global.findScope(offset: 14), equals(first));
+      expect(global.findScope(offset: 15), equals(second));
+      expect(global.findScope(offset: 19), equals(second));
+    });
+  });
+}