Skip to content

Commit 071c529

Browse files
authored
Use nvm's "lts/*" alias for the latest stable Node (#872)
Follow-up from #859. It turns out that nvm's "stable" alias is deprecated, Node itself doesn't consider odd-numbered releases "stable" in any real sense, and pertinently the fibers package doesn't guarantee support for them. By only building on LTS releases we avoid all these shenanigans.
1 parent 1a5102b commit 071c529

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

.travis.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,7 @@ jobs:
8282
- &node-tests
8383
name: Node tests | Dart stable | Node stable
8484
language: node_js
85-
# TODO(nweiz): Make this "stable" when laverdet/node-fibers#420 is fixed.
86-
node_js: 12
85+
node_js: lts/*
8786
install: pub run grinder before-test
8887
script: tool/travis/task/node_tests.sh
8988
- <<: *node-tests
@@ -154,8 +153,7 @@ jobs:
154153
- secure: "Iv6UKB6mH0GLkRQtaLeZnoW0QMmXbzGVX/QO+vvT26yWvqlW/ik+YeHB+4VLZFz/4xezukkztVENdxNDCnrQA/NX7fVhjqj4Px2JQau0V0ljYN64H+o0oxlBeMQqnsVOJcsU7DuPFPErYixkE3yuN6DqIYE+DYe3fVQg/1RBCs2z1nejg4udbZG7D0yfrxZSCckhsyBH1Ej72FhMGMaFq7k7IMC7f/sGYZZYsOe2WKmsYF35hyL/twIXKBNxjPat1HmsVT/3VOUIF+doO26BxthEc68Tmp3SHucEXHWPEjk9N87DxLClGkHvvZ2PUK9nYB9/KqxvJqf/AcDO34vS0lAU809Eov7dK/19WE1GtgA/gL0B/nh2QYbWpbO/HPzxFqOYwfzLtAXvwUr45eMNxmh1yupbAtxRvst7ZO/UTC+awW55AXnVd4jiTzZ/jqV52aGbClN+escPZCYXgYosvJLK3G4xLYCY4TTC99riBQZ0MDLfCt35+RivjNLVf8vecGT8WTmVQySzq0Cthy/9SCp1OzWT5roY2rzkwvR4R0+42f48qyDU/buUgPBsw9zwCabWVoB0p4hflalEhc9EwbRn5oDI0NHwXE0r83movx+JHHPBau1zwX53DJSpSFXnDPi6KaNpg52wyuIIzO90zA7FZTRR9My38AzYgVaKkdE="
155154
script: skip
156155
language: node_js
157-
# TODO(nweiz): Make this "stable" when laverdet/node-fibers#420 is fixed.
158-
node_js: 12
156+
node_js: lts/*
159157
deploy:
160158
provider: script
161159
script: tool/travis/deploy/npm.sh
@@ -225,8 +223,7 @@ jobs:
225223
env: *github-env
226224
script: skip
227225
language: node_js
228-
# TODO(nweiz): Make this "stable" when laverdet/node-fibers#420 is fixed.
229-
node_js: 12
226+
node_js: lts/*
230227
deploy:
231228
provider: script
232229
script: pub run grinder update-bazel

0 commit comments

Comments
 (0)