Address review feedbacks

ntkme · ntkme · commit 6f4de3140850 · 2025-07-21T16:37:28.000-07:00
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -184,7 +184,7 @@ jobs:
       - name: Initialize embedded host
         run: |
           npm install
-          npm run init -- --compiler-path=.. --language-path=../build/language --compiler-js=${{ matrix.js && 'true' || 'false' }}
+          npm run init -- --compiler-path=.. --language-path=../build/language ${{ matrix.js && '--compiler-js' || '' }}
           npm run compile
         working-directory: embedded-host-node
 
diff --git a/lib/src/embedded/concurrency.dart b/lib/src/embedded/concurrency.dart
@@ -1,10 +1,11 @@
-// Copyright 2024 Google Inc. Use of this source code is governed by an
+// Copyright 2025 Google Inc. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
 import 'dart:ffi';
 
 /// More than MaxMutatorThreadCount isolates in the same isolate group
 /// can deadlock the Dart VM.
+///
 /// See https://github.com/sass/dart-sass/pull/2019
 int get concurrencyLimit => sizeOf<IntPtr>() <= 4 ? 7 : 15;
diff --git a/lib/src/embedded/isolate_main.dart b/lib/src/embedded/isolate_main.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google Inc. Use of this source code is governed by an
+// Copyright 2025 Google Inc. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/lib/src/embedded/js/concurrency.dart b/lib/src/embedded/js/concurrency.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google Inc. Use of this source code is governed by an
+// Copyright 2025 Google Inc. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/lib/src/embedded/js/executable.dart b/lib/src/embedded/js/executable.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google Inc. Use of this source code is governed by an
+// Copyright 2025 Google Inc. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/lib/src/embedded/js/io.dart b/lib/src/embedded/js/io.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google Inc. Use of this source code is governed by an
+// Copyright 2025 Google Inc. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/lib/src/embedded/js/isolate.dart b/lib/src/embedded/js/isolate.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC. Use of this source code is governed by an
+// Copyright 2025 Google LLC. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/lib/src/embedded/js/isolate_main.dart b/lib/src/embedded/js/isolate_main.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google Inc. Use of this source code is governed by an
+// Copyright 2025 Google Inc. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/lib/src/embedded/js/js.dart b/lib/src/embedded/js/js.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google Inc. Use of this source code is governed by an
+// Copyright 2025 Google Inc. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/lib/src/embedded/js/reusable_isolate.dart b/lib/src/embedded/js/reusable_isolate.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google Inc. Use of this source code is governed by an
+// Copyright 2025 Google Inc. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/lib/src/embedded/js/sync_message_port.dart b/lib/src/embedded/js/sync_message_port.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC. Use of this source code is governed by an
+// Copyright 2025 Google LLC. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/lib/src/embedded/js/sync_receive_port.dart b/lib/src/embedded/js/sync_receive_port.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google Inc. Use of this source code is governed by an
+// Copyright 2025 Google Inc. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/lib/src/embedded/js/worker_threads.dart b/lib/src/embedded/js/worker_threads.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google Inc. Use of this source code is governed by an
+// Copyright 2025 Google Inc. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/lib/src/embedded/options.dart b/lib/src/embedded/options.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google Inc. Use of this source code is governed by an
+// Copyright 2025 Google Inc. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/lib/src/embedded/sync_receive_port.dart b/lib/src/embedded/sync_receive_port.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google Inc. Use of this source code is governed by an
+// Copyright 2025 Google Inc. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/lib/src/embedded/vm/sync_receive_port.dart b/lib/src/embedded/vm/sync_receive_port.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google Inc. Use of this source code is governed by an
+// Copyright 2025 Google Inc. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/test/embedded/dart/file_importer_test.dart b/test/embedded/dart/file_importer_test.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC. Use of this source code is governed by an
+// Copyright 2025 Google LLC. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/test/embedded/dart/function_test.dart b/test/embedded/dart/function_test.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC. Use of this source code is governed by an
+// Copyright 2025 Google LLC. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/test/embedded/dart/importer_test.dart b/test/embedded/dart/importer_test.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC. Use of this source code is governed by an
+// Copyright 2025 Google LLC. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/test/embedded/dart/length_delimited_test.dart b/test/embedded/dart/length_delimited_test.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC. Use of this source code is governed by an
+// Copyright 2025 Google LLC. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/test/embedded/dart/protocol_test.dart b/test/embedded/dart/protocol_test.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC. Use of this source code is governed by an
+// Copyright 2025 Google LLC. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/test/embedded/dart_test.dart b/test/embedded/dart_test.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC. Use of this source code is governed by an
+// Copyright 2025 Google LLC. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/test/embedded/node/file_importer_test.dart b/test/embedded/node/file_importer_test.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC. Use of this source code is governed by an
+// Copyright 2025 Google LLC. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/test/embedded/node/function_test.dart b/test/embedded/node/function_test.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC. Use of this source code is governed by an
+// Copyright 2025 Google LLC. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/test/embedded/node/importer_test.dart b/test/embedded/node/importer_test.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC. Use of this source code is governed by an
+// Copyright 2025 Google LLC. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/test/embedded/node/length_delimited_test.dart b/test/embedded/node/length_delimited_test.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC. Use of this source code is governed by an
+// Copyright 2025 Google LLC. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/test/embedded/node/protocol_test.dart b/test/embedded/node/protocol_test.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC. Use of this source code is governed by an
+// Copyright 2025 Google LLC. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
diff --git a/test/embedded/node_test.dart b/test/embedded/node_test.dart
@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC. Use of this source code is governed by an
+// Copyright 2025 Google LLC. Use of this source code is governed by an
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// Copyright 2024 Google Inc. Use of this source code is governed by an`
	`1`	`+// Copyright 2025 Google Inc. Use of this source code is governed by an`
`2`	`2`	`// MIT-style license that can be found in the LICENSE file or at`
`3`	`3`	`// https://opensource.org/licenses/MIT.`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-// Copyright 2024 Google LLC. Use of this source code is governed by an`
	`1`	`+// Copyright 2025 Google LLC. Use of this source code is governed by an`
`2`	`2`	`// MIT-style license that can be found in the LICENSE file or at`
`3`	`3`	`// https://opensource.org/licenses/MIT.`
`4`	`4`