Skip to content

Commit a148c5c

Browse files
committed
Skip Node tests on Dart dev until dart-lang/sdk#40152 is fixed
We were still seeing errors when passing --use-old-rti, so we'll just skip it entirely for now.
1 parent 6118ded commit a148c5c

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

.travis.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,10 @@ jobs:
9191
node_js: lts/dubnium
9292
- <<: *node-tests
9393
os: osx
94-
- <<: *node-tests
95-
name: Node tests | Dart dev | Node stable
96-
env: DART_CHANNEL=dev
94+
# TODO(nweiz): Re-enable this when dart-lang/sdk#40152 is fixed.
95+
# - <<: *node-tests
96+
# name: Node tests | Dart dev | Node stable
97+
# env: DART_CHANNEL=dev
9798

9899
# Miscellaneous checks.
99100
- name: static analysis

tool/grind/npm.dart

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import 'package:grinder/grinder.dart';
1010
import 'package:meta/meta.dart';
1111
import 'package:node_preamble/preamble.dart' as preamble;
1212
import 'package:path/path.dart' as p;
13-
import 'package:pub_semver/pub_semver.dart';
1413
import 'package:source_span/source_span.dart';
1514

1615
import 'utils.dart';
@@ -35,11 +34,6 @@ void _js({@required bool release}) {
3534
'-Dnode=true',
3635
'-Dversion=$version',
3736
'-Ddart-version=$dartVersion',
38-
39-
// Work around dart-lang/sdk#40152.
40-
if (dartVersion >= Version.parse("2.8.0-dev.2.0"))
41-
'--use-old-rti',
42-
4337
// We use O4 because:
4438
//
4539
// * We don't care about the string representation of types.

0 commit comments

Comments
 (0)