Skip to content

Commit aa18e65

Browse files
committed
Code review
1 parent 5957a57 commit aa18e65

File tree

10 files changed

+14
-11
lines changed

10 files changed

+14
-11
lines changed

lib/src/ast/node.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ abstract class AstNode {
1515
/// Returns an [AstNode] that doesn't have any data and whose span is
1616
/// generated by [callback].
1717
///
18-
/// Anumber of APIs take [AstNode]s instead of spans because computing spans
18+
/// A number of APIs take [AstNode]s instead of spans because computing spans
1919
/// eagerly can be expensive. This allows arbitrary spans to be passed to
20-
/// those callbacks while sitll being lazily computed.
20+
/// those callbacks while still being lazily computed.
2121
factory AstNode.fake(FileSpan Function() callback) = _FakeAstNode;
2222

2323
AstNode();

lib/src/async_environment.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ class AsyncEnvironment {
235235
/// If [namespace] is passed, the module is made available under that
236236
/// namespace.
237237
///
238-
/// Throws a [SassException] if there's already a module with the given
238+
/// Throws a [SassScriptException] if there's already a module with the given
239239
/// [namespace], or if [namespace] is `null` and [module] defines a variable
240240
/// with the same name as a variable defined in this environment.
241241
void addModule(Module module, AstNode nodeWithSpan, {String namespace}) {

lib/src/callable.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ export 'callable/user_defined.dart';
6565
/// access a string's length in code points.
6666
@sealed
6767
abstract class Callable extends AsyncCallable {
68-
@Deprecated('Use `new Callable.function` instead.')
68+
@Deprecated('Use `Callable.function` instead.')
6969
factory Callable(String name, String arguments,
7070
ext.Value callback(List<ext.Value> arguments)) =>
7171
Callable.function(name, arguments, callback);

lib/src/callable/async.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ abstract class AsyncCallable {
2323
/// The callable's name.
2424
String get name;
2525

26-
@Deprecated('Use `new AsyncCallable.function` instead.')
26+
@Deprecated('Use `AsyncCallable.function` instead.')
2727
factory AsyncCallable(String name, String arguments,
2828
FutureOr<ext.Value> callback(List<ext.Value> arguments)) =>
2929
AsyncCallable.function(name, arguments, callback);

lib/src/functions/color.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -776,7 +776,8 @@ SassColor _transparentize(List<Value> arguments) {
776776
/// Like [fuzzyRound], but returns `null` if [number] is `null`.
777777
int _fuzzyRoundOrNull(num number) => number == null ? null : fuzzyRound(number);
778778

779-
/// Like [new BuiltInCallable.function], but always sets the URL to `sass:math`.
779+
/// Like [new BuiltInCallable.function], but always sets the URL to
780+
/// `sass:color`.
780781
BuiltInCallable _function(
781782
String name, String arguments, Value callback(List<Value> arguments)) =>
782783
BuiltInCallable.function(name, arguments, callback, url: "sass:color");

lib/src/functions/list.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ final _separator = _function(
131131
final _isBracketed = _function("is-bracketed", r"$list",
132132
(arguments) => SassBoolean(arguments[0].hasBrackets));
133133

134-
/// Like [new BuiltInCallable.function], but always sets the URL to `sass:math`.
134+
/// Like [new BuiltInCallable.function], but always sets the URL to `sass:list`.
135135
BuiltInCallable _function(
136136
String name, String arguments, Value callback(List<Value> arguments)) =>
137137
BuiltInCallable.function(name, arguments, callback, url: "sass:list");

lib/src/functions/map.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ final _hasKey = _function("has-key", r"$map, $key", (arguments) {
7373
return SassBoolean(map.contents.containsKey(key));
7474
});
7575

76-
/// Like [new BuiltInCallable.function], but always sets the URL to `sass:math`.
76+
/// Like [new BuiltInCallable.function], but always sets the URL to `sass:map`.
7777
BuiltInCallable _function(
7878
String name, String arguments, Value callback(List<Value> arguments)) =>
7979
BuiltInCallable.function(name, arguments, callback, url: "sass:map");

lib/src/functions/meta.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ final global = UnmodifiableListView([
5858
})
5959
]);
6060

61-
/// Like [new BuiltInCallable.function], but always sets the URL to `sass:math`.
61+
/// Like [new BuiltInCallable.function], but always sets the URL to `sass:meta`.
6262
BuiltInCallable _function(
6363
String name, String arguments, Value callback(List<Value> arguments)) =>
6464
BuiltInCallable.function(name, arguments, callback, url: "sass:meta");

lib/src/functions/selector.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,8 @@ CompoundSelector _prependParent(CompoundSelector compound) {
139139
}
140140
}
141141

142-
/// Like [new BuiltInCallable.function], but always sets the URL to `sass:math`.
142+
/// Like [new BuiltInCallable.function], but always sets the URL to
143+
/// `sass:selector`.
143144
BuiltInCallable _function(
144145
String name, String arguments, Value callback(List<Value> arguments)) =>
145146
BuiltInCallable.function(name, arguments, callback, url: "sass:selector");

lib/src/functions/string.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,8 @@ int _codepointForIndex(int index, int lengthInCodepoints,
168168
return result;
169169
}
170170

171-
/// Like [new BuiltInCallable.function], but always sets the URL to `sass:math`.
171+
/// Like [new BuiltInCallable.function], but always sets the URL to
172+
/// `sass:string`.
172173
BuiltInCallable _function(
173174
String name, String arguments, Value callback(List<Value> arguments)) =>
174175
BuiltInCallable.function(name, arguments, callback, url: "sass:string");

0 commit comments

Comments
 (0)