Always create scopes for nested imports

Author: nex3

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.23.8
+
+* **Potentially breaking bug fix:** Members loaded through a nested `@import`
+  are no longer ever accessible outside that nested context.
+
 ## 1.23.7
 
 * No user-visible changes.

lib/src/ast/sass/statement/if_rule.dart

@@ -6,8 +6,10 @@ import 'package:source_span/source_span.dart';
 
 import '../../../visitor/interface/statement.dart';
 import '../expression.dart';
+import '../import/dynamic.dart';
 import '../statement.dart';
 import 'function_rule.dart';
+import 'import_rule.dart';
 import 'mixin_rule.dart';
 import 'variable_declaration.dart';
 
@@ -69,7 +71,9 @@ class IfClause {
       : hasDeclarations = children.any((child) =>
             child is VariableDeclaration ||
             child is FunctionRule ||
-            child is MixinRule);
+            child is MixinRule ||
+            (child is ImportRule &&
+                child.imports.any((import) => import is DynamicImport)));
 
   String toString() =>
       (expression == null ? "@else" : "@if $expression") +

lib/src/ast/sass/statement/parent.dart

@@ -2,8 +2,10 @@
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
+import '../import/dynamic.dart';
 import '../statement.dart';
 import 'function_rule.dart';
+import 'import_rule.dart';
 import 'mixin_rule.dart';
 import 'variable_declaration.dart';
 
@@ -12,13 +14,16 @@ abstract class ParentStatement implements Statement {
   /// The child statements of this statement.
   final List<Statement> children;
 
-  /// Whether any of [children] is a variable, function, or mixin declaration.
+  /// Whether any of [children] is a variable, function, or mixin declaration,
+  /// or a dynamic import rule.
   final bool hasDeclarations;
 
   ParentStatement(this.children)
       : hasDeclarations = children?.any((child) =>
                 child is VariableDeclaration ||
                 child is FunctionRule ||
-                child is MixinRule) ??
+                child is MixinRule ||
+                (child is ImportRule &&
+                    child.imports.any((import) => import is DynamicImport))) ??
             false;
 }

pubspec.yaml

@@ -1,5 +1,5 @@
 name: sass
-version: 1.23.7
+version: 1.23.8-dev
 description: A Sass implementation in Dart.
 author: Sass Team
 homepage: https://github.com/sass/dart-sass