Skip to content

Commit b27c3ae

Browse files
authored
Fix CI by pinning postcss version to 8.5.5 and disable app armor for browser tests (#2606)
* Pin postcss version to 8.5.5 Not using 8.5.6 yet because it needs additional changes for type compatibility * disable app armor for browser tests See puppeteer/puppeteer#12818 Ubuntu 23+ doesn't like running puppeteer without disabling AppArmor.
1 parent a42380f commit b27c3ae

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

.github/workflows/test.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -309,13 +309,14 @@ jobs:
309309

310310
- run: dart run grinder pkg-npm-dev
311311
env: {UPDATE_SASS_SASS_REPO: false}
312-
- run: sudo chmod 4755 /opt/google/chrome/chrome-sandbox
312+
# See https://github.com/puppeteer/puppeteer/issues/12818
313+
# Ubuntu 23+ doesn't like running puppeteer without disabling AppArmor.
314+
- name: Disable AppArmor
315+
run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0
313316
- name: Run tests
314317
run: dart run test -p chrome -j 2
315318
env:
316319
CHROME_EXECUTABLE: chrome
317-
# See https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md#option-3_the-safest-way
318-
CHROME_DEVEL_SANDBOX: /opt/google/chrome/chrome-sandbox
319320

320321
sass_parser_tests:
321322
name: "sass-parser Tests | Dart ${{ matrix.dart_channel }} | Node ${{ matrix.node-version }}"
@@ -328,7 +329,7 @@ jobs:
328329
node-version: ['lts/*']
329330
include:
330331
# Test older LTS versions
331-
#
332+
#
332333
# TODO: Test on lts/-2 and lts/-3 once they support
333334
# `structuredClone()` (that is, once they're v18 or later).
334335
- os: ubuntu-latest

pkg/sass-parser/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"test": "jest"
3232
},
3333
"dependencies": {
34-
"postcss": ">=8.4.41 <8.6.0",
34+
"postcss": "8.5.5",
3535
"sass": "file:../../build/npm"
3636
},
3737
"devDependencies": {

0 commit comments

Comments
 (0)