Skip to content

Commit e6391d3

Browse files
authored
Always limit the repetition of loggers (#2391)
See #2390. This is definitely not the correct long-term solution—we only want to limit repetition in the context of a single batch of compilations, and this doesn't always respect `--verbose`—but it's way better to display too few deprecations than too many.
1 parent ab19f94 commit e6391d3

File tree

8 files changed

+30
-8
lines changed

8 files changed

+30
-8
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 1.80.1
2+
3+
* Fix a bug where repeated deprecation warnings were not automatically limited.
4+
15
## 1.80.0
26

37
* `@import` is now officially deprecated, as are global built-in functions that

lib/src/async_import_cache.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,6 +380,9 @@ final class AsyncImportCache {
380380
silenceDeprecations: {...?silenceDeprecations},
381381
fatalDeprecations: {...?fatalDeprecations},
382382
futureDeprecations: {...?futureDeprecations},
383-
limitRepetition: false);
383+
// TODO - sass/dart-sass#2390: We should limit repetition within a given
384+
// compilation while allowing it across different compilations (such as
385+
// with `--watch`).
386+
limitRepetition: true);
384387
}
385388
}

lib/src/import_cache.dart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// DO NOT EDIT. This file was generated from async_import_cache.dart.
66
// See tool/grind/synchronize.dart for details.
77
//
8-
// Checksum: e043f2a3dafb741a6f053a7c1785b1c9959242f5
8+
// Checksum: f459089f21fcbfca2d073ba73a5bcf4e98ecab1b
99
//
1010
// ignore_for_file: unused_import
1111

@@ -375,6 +375,9 @@ final class ImportCache {
375375
silenceDeprecations: {...?silenceDeprecations},
376376
fatalDeprecations: {...?fatalDeprecations},
377377
futureDeprecations: {...?futureDeprecations},
378-
limitRepetition: false);
378+
// TODO - sass/dart-sass#2390: We should limit repetition within a given
379+
// compilation while allowing it across different compilations (such as
380+
// with `--watch`).
381+
limitRepetition: true);
379382
}
380383
}

pkg/sass-parser/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.3.1
2+
3+
* No user-visible changes.
4+
15
## 0.3.0
26

37
* No user-visible changes.

pkg/sass-parser/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "sass-parser",
3-
"version": "0.3.0",
3+
"version": "0.3.1",
44
"description": "A PostCSS-compatible wrapper of the official Sass parser",
55
"repository": "sass/sass",
66
"author": "Google Inc.",

pkg/sass_api/CHANGELOG.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
1+
## 13.1.1
2+
3+
* Make `AsyncImporterCache.wrapLogger()` and `ImporterCache.wrapLogger()` always
4+
limit the repetition of deprecations. this is unlikely to be the long-term
5+
behavior, but it's necessary to avoid flooding users with deprecations in the
6+
short term.
7+
18
## 13.1.0
29

3-
* No user-visible changes.
10+
* Add `AsyncImporterCache.wrapLogger()` and `ImporterCache.wrapLogger()`
11+
methods, which wrap a given logger to apply deprecation options to it.
412

513
## 13.0.1
614

pkg/sass_api/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ name: sass_api
22
# Note: Every time we add a new Sass AST node, we need to bump the *major*
33
# version because it's a breaking change for anyone who's implementing the
44
# visitor interface(s).
5-
version: 13.1.0
5+
version: 13.1.1
66
description: Additional APIs for Dart Sass.
77
homepage: https://github.com/sass/dart-sass
88

99
environment:
1010
sdk: ">=3.0.0 <4.0.0"
1111

1212
dependencies:
13-
sass: 1.80.0
13+
sass: 1.80.1
1414

1515
dev_dependencies:
1616
dartdoc: ^8.0.14

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: sass
2-
version: 1.80.0
2+
version: 1.80.1
33
description: A Sass implementation in Dart.
44
homepage: https://github.com/sass/dart-sass
55

0 commit comments

Comments
 (0)