Skip to content

Commit 342887d

Browse files
committed
Specify node versions a la sass/sass-spec#1957
1 parent 5352c67 commit 342887d

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ defaults:
55

66
env:
77
PROTOC_VERSION: 3.x
8-
DEFAULT_NODE_VERSION: 20.x # If changing this, also change jobs.tests.strategy.matrix.node_version
98

109
on:
1110
push:
@@ -22,7 +21,7 @@ jobs:
2221
- uses: actions/checkout@v2
2322
- uses: actions/setup-node@v2
2423
with:
25-
node-version: ${{ env.DEFAULT_NODE_VERSION }}
24+
node-version: 'lts/*'
2625
check-latest: true
2726

2827
- name: Check out the language repo
@@ -43,7 +42,7 @@ jobs:
4342
strategy:
4443
matrix:
4544
os: [ubuntu, macos, windows]
46-
node-version: [20.x, 18.x, 16.x] # If changing this, also change env.DEFAULT_NODE_VERSION
45+
node-version: ['lts/*', 'lts/-1', 'lts/-2']
4746
fail-fast: false
4847

4948
steps:
@@ -73,9 +72,6 @@ jobs:
7372
- run: npm run compile
7473
- run: node test/after-compile-test.mjs
7574

76-
# The versions should be kept up-to-date with the latest LTS Node releases.
77-
# They next need to be rotated October 2021. See
78-
# https://github.com/nodejs/Release.
7975
sass_spec:
8076
name: 'JS API Tests | Node ${{ matrix.node_version }} | ${{ matrix.os }}'
8177
runs-on: ${{ matrix.os }}-latest
@@ -84,13 +80,13 @@ jobs:
8480
fail-fast: false
8581
matrix:
8682
os: [ubuntu, windows, macos]
87-
node_version: [20]
83+
node_version: ['lts/*']
8884
include:
8985
# Include LTS versions on Ubuntu
9086
- os: ubuntu
91-
node_version: 18
87+
node_version: lts/-1
9288
- os: ubuntu
93-
node_version: 16
89+
node_version: lts/-2
9490

9591
steps:
9692
- uses: actions/checkout@v2
@@ -147,7 +143,7 @@ jobs:
147143
- uses: actions/checkout@v2
148144
- uses: actions/setup-node@v2
149145
with:
150-
node-version: ${{ env.DEFAULT_NODE_VERSION }}
146+
node-version: 'lts/*'
151147
check-latest: true
152148
registry-url: 'https://registry.npmjs.org'
153149
- run: npm install

0 commit comments

Comments
 (0)