Skip to content

Commit 0c3b2b4

Browse files
committed
Switch some from ISSUE_TEMPLATE.md to CONTRIBUTING.md
1 parent 0377e0a commit 0c3b2b4

File tree

2 files changed

+56
-53
lines changed

2 files changed

+56
-53
lines changed

.github/CONTRIBUTING.md

Lines changed: 54 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,61 @@
55
The following is a set of guidelines for contributing to LibSass, which is hosted in the [Sass Organization](https://github.com/sass) on GitHub.
66
These are just guidelines, not rules, use your best judgment and feel free to propose changes to this document in a pull request.
77

8-
LibSass is a library that implements a [sass language] [1] compiler. As such it does not directly interface with end users (frontend developers).
8+
LibSass is a library that implements a [sass language] [8] compiler. As such it does not directly interface with end users (frontend developers).
99
For direct contributions to the LibSass code base you will need to have at least a rough idea of C++, we will not lie about that.
1010
But there are other ways to contribute to the progress of LibSass. All contributions are done via github pull requests.
1111

12-
You can contribute to the [LibSass documentation] [2] or provide additional [spec tests] [3] (we will gladly point you in the direction
13-
of the dirty corners in LibSass). Foremost we rely on good and concise bug reports for issues the spec tests do not yet catch.
12+
You can also contribute to the LibSass [documentation] [9] or provide additional [spec tests] [10] (and we will gladly point you in the
13+
direction for corners that lack test coverage). Foremost we rely on good and concise bug reports for issues the spec tests do not yet catch.
1414

15-
[1]: http://sass-lang.com/
16-
[2]: https://github.com/sass/libsass/tree/master/docs
17-
[3]: https://github.com/sass/sass-spec
15+
## Precheck: My Sass isn't compiling
16+
- [ ] Check if you can reproduce the issue via [SourceMap Inspector] [5] (updated regularly).
17+
- [ ] Validate official ruby sass compiler via [SassMeister] [6] produces your expected result.
18+
- [ ] Search for similar issue in [LibSass] [1] and [node-sass] [2] (include closed tickets)
19+
- [ ] Optionally test your code directly with [sass] [7] or [sassc] [2] ([installer] [4])
20+
21+
## Precheck: My build/install fails
22+
- [ ] Problems with building or installing libsass should be directed to implementors first!
23+
- [ ] Except for issues directly verified via sassc or LibSass own build (make/autotools9
24+
25+
## Craft a meaningfull error report
26+
- [ ] Include the version of libsass and the implementor (i.e. node-sass or sassc)
27+
- [ ] Include information about your operating system and environment (i.e. io.js)
28+
- [ ] Either create a self contained sample that shows your issue ...
29+
- [ ] ... or provide it as a fetchable (github preferred) archive/repo
30+
- [ ] ... and include a step by step list of command to get all dependencies
31+
- [ ] Make it clear if you use indented or/and scss syntax
32+
33+
## My error is hiding in a big code base
34+
1. we do not have time to support your code base!
35+
2. to fix occuring issues we need precise bug reports
36+
3. the more precise you are, the faster we can help you
37+
4. lazy reports get overlooked even when exposing serious bugs
38+
5. it's not hard to do, it only takes time
39+
- [ ] Make sure you saved the current state (i.e. commit to git)
40+
- [ ] Start by uncommenting blocks in the initial source file
41+
- [ ] Check if the problem is still there after each edit
42+
- [ ] Repeat until the problem goes away
43+
- [ ] Inline imported files as you go along
44+
- [ ] Finished once you cannot remove more
45+
- [ ] The emphasis is on the word "repeat" ...
46+
47+
## What makes a code test case
48+
49+
Important is that someone else can get the test case up and running to reproduce it locally. For this
50+
we urge you to verify that your sample yields the expected result by testing it via [SassMeister] [6]
51+
or directly via ruby sass or node-sass (or any other libsass implementor) before submitting your bug
52+
report. Once you verified all of the above, you may use the template below to file your bug report.
53+
54+
55+
[1]: https://github.com/sass/libsass/issues?utf8=%E2%9C%93&q=is%3Aissue
56+
[2]: https://github.com/sass/node-sass/issues?utf8=%E2%9C%93&q=is%3Aissue
57+
[3]: https://github.com/sass/sassc
58+
[4]: http://libsass.ocbnet.ch/installer/
59+
[5]: http://libsass.ocbnet.ch/srcmap/
60+
[6]: http://www.sassmeister.com/
61+
[7]: https://rubygems.org/gems/sass
62+
63+
[8]: http://sass-lang.com/
64+
[9]: https://github.com/sass/libsass/tree/master/docs
65+
[10]: https://github.com/sass/sass-spec

.github/ISSUE_TEMPLATE.md

Lines changed: 2 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,3 @@
1-
## Precheck: My Sass isn't compiling
2-
- [ ] Check if you can reproduce the issue via [SourceMap Inspector] [5] (updated regularly).
3-
- [ ] Validate official ruby sass compiler via [SassMeister] [6] produces your expected result.
4-
- [ ] Search for similar issue in [LibSass] [1] and [node-sass] [2] (include closed tickets)
5-
- [ ] Optionally test your code directly with [sass] [7] or [sassc] [2] ([installer] [4])
6-
7-
## Precheck: My build/install fails
8-
- [ ] Problems with building or installing libsass should be directed to implementors first!
9-
- [ ] Except for issues directly verified via sassc or LibSass own build (make/autotools9
10-
11-
## Craft a meaningfull error report
12-
- [ ] Include the version of libsass and the implementor (i.e. node-sass or sassc)
13-
- [ ] Include information about your operating system and environment (i.e. io.js)
14-
- [ ] Either create a self contained sample that shows your issue ...
15-
- [ ] ... or provide it as a fetchable (github preferred) archive/repo
16-
- [ ] ... and include a step by step list of command to get all dependencies
17-
- [ ] Make it clear if you use indented or/and scss syntax
18-
19-
## My error is hiding in a big code base
20-
1. we do not have time to support your code base!
21-
2. to fix occuring issues we need precise bug reports
22-
3. the more precise you are, the faster we can help you
23-
4. lazy reports get overlooked even when exposing serious bugs
24-
5. it's not hard to do, it only takes time
25-
- [ ] Make sure you saved the current state (i.e. commit to git)
26-
- [ ] Start by uncommenting blocks in the initial source file
27-
- [ ] Check if the problem is still there after each edit
28-
- [ ] Repeat until the problem goes away
29-
- [ ] Inline imported files as you go along
30-
- [ ] Finished once you cannot remove more
31-
- [ ] The emphasis is on the word "repeat" ...
32-
33-
## What makes a code test case
34-
35-
Important is that someone else can get the test case up and running to reproduce it locally. For this
36-
we urge you to verify that your sample yields the expected result by testing it via [SassMeister] [6]
37-
or directly via ruby sass or node-sass (or any other libsass implementor) before submitting your bug
38-
report. Once you verified all of the above, you may use the template below to file your bug report.
39-
401
### Title: Be as meaningfull as possible in 60 chars if possible
412

423
input.scss
@@ -46,7 +7,7 @@ test {
467
}
478
```
489

49-
libsass 3.5.5
10+
[libsass 3.5.5] [1]
5011
```css
5112
test {
5213
content: bar; }
@@ -65,10 +26,4 @@ node-sass 3.3.3 (Wrapper) [JavaScript]
6526
libsass 3.2.5 (Sass Compiler) [C/C++]
6627
```
6728

68-
[1]: https://github.com/sass/libsass/issues?utf8=%E2%9C%93&q=is%3Aissue
69-
[2]: https://github.com/sass/node-sass/issues?utf8=%E2%9C%93&q=is%3Aissue
70-
[3]: https://github.com/sass/sassc
71-
[4]: http://libsass.ocbnet.ch/installer/
72-
[5]: http://libsass.ocbnet.ch/srcmap/
73-
[6]: http://www.sassmeister.com/
74-
[7]: https://rubygems.org/gems/sass
29+
[1]: http://libsass.ocbnet.ch/srcmap/#dGVzdCB7CiAgY29udGVudDogYmFyOyB9Cg==

0 commit comments

Comments
 (0)