Fix a memory leak in rgba_2

glebm · xzyfer · commit 4589d07cd645 · 2018-11-21T21:47:58.000+11:00
ALPHA_NUM throws on invalid argument. When this happened, `new_c` was never freed.
diff --git a/src/fn_colors.cpp b/src/fn_colors.cpp
@@ -102,10 +102,10 @@ namespace Sass {
         return SASS_MEMORY_NEW(String_Constant, pstate, strm.str());
       }
 
-      Color_Ptr new_c = SASS_MEMORY_COPY(c_arg);
+      Color_Obj new_c = SASS_MEMORY_COPY(c_arg);
       new_c->a(ALPHA_NUM("$alpha"));
       new_c->disp("");
-      return new_c;
+      return new_c.detach();
     }
 
     ////////////////

Original file line number	Diff line number	Diff line change
`@@ -102,10 +102,10 @@ namespace Sass {`
`102`	`102`	`return SASS_MEMORY_NEW(String_Constant, pstate, strm.str());`
`103`	`103`	`}`
`104`	`104`
`105`		`- Color_Ptr new_c = SASS_MEMORY_COPY(c_arg);`
	`105`	`+ Color_Obj new_c = SASS_MEMORY_COPY(c_arg);`
`106`	`106`	`new_c->a(ALPHA_NUM("$alpha"));`
`107`	`107`	`new_c->disp("");`
`108`		`- return new_c;`
	`108`	`+ return new_c.detach();`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`////////////////`